This repository was archived by the owner on Nov 1, 2020. It is now read-only.
Merge changes from TFS #5852
Merged
Merge changes from TFS #5852
+10
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…, if the struct fits in the SIMD registers, given that the S and D registers overlap and how the UniversalTransitionThunk and CallDescrWorker copy D values, we treat the HFA struct as an HFA of doubles instead of floats (And we double the size of the struct during this processing). The issue however is when there aren't enough SIMD registers to fit the HFA struct, and we're forced to pass it on the stack. In that case, we shouldn't double the size of the struct and treat the floats as doubles. Also fixing the test to exclude invalid scenarios from arm64 (the scenario is invalid because the return buffer pointer is passed using a special x8 register, and not using the x0-7 registers like the rest of the arguments) [tfs-changeset: 1701853]
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When merging, this PR, please ensure a merge commit is created as automation requires the merge commit. Do not 'Squash and merge' or 'Rebase and merge'!