Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix regression with lambda parameters due to verbatim identifier work #121

Merged
merged 1 commit into from
May 30, 2018

Conversation

DustinCampbell
Copy link
Member

Fixes #119
Fixes #120

The verbatim identifier work removed a \b between the type and identifier for lambda parameters which meant that a parameter name like longParameterName1 with no type would match incorrectly. Instead, of matching as a parameter name, longParameterNam would match as a type and e1 would match as the parameter name. This change inserts a \s+ between the type and parameter name to address the fact that there's no longer a \b. There is further to rationalize all of this across the grammar.

@DustinCampbell DustinCampbell merged commit 4695572 into dotnet:master May 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant