Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Event fields enhancement #266

Merged
merged 1 commit into from
Aug 2, 2023
Merged

Event fields enhancement #266

merged 1 commit into from
Aug 2, 2023

Conversation

wise0704
Copy link
Contributor

@wise0704 wise0704 commented Aug 2, 2023

  • multiple event fields across multiple lines
  • default value assignment of each event field

fixes #118

P.S. All these PRs because the semantic highlighter marks every single keyword as plainKeyword which overrides everything as keyword.cs, even if it already had more specific scope like keyword.other.X.Y.cs.
I just wanted separate colours for some special keywords so I turned off theme colour for keyword.cs and this happens...

- multiple event fields across multiple lines
- default value assignment of each
@JoeRobich
Copy link
Member

P.S. All these PRs because the semantic highlighter marks every single keyword as plainKeyword which overrides everything as keyword.cs, even if it already had more specific scope like keyword.other.X.Y.cs.

Yeah, Roslyn drives the semantic highlighting and was built to drive the highlighting in VS which has never had more specific keyword classifications. Perhaps, now that it also powers the C# LSP, we could push for additional details to be surfaced as token modifiers.

CC: @dibarbet

Copy link
Member

@JoeRobich JoeRobich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for all these improvements!

@JoeRobich JoeRobich merged commit d5fcb79 into dotnet:main Aug 2, 2023
2 checks passed
@dibarbet
Copy link
Member

dibarbet commented Aug 2, 2023

Perhaps, now that it also powers the C# LSP, we could push for additional details to be surfaced as token modifiers.

CC: @dibarbet

Tracking issue dotnet/vscode-csharp#5993

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Event keyword is not highlighted when assigned to a lambda expression
3 participants