Unsafe keywords #288
Merged
Unsafe keywords #288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoeRobich
approved these changes
Sep 1, 2023
asottile
reviewed
Nov 5, 2023
| @@ -2761,29 +2782,60 @@ repository: | |||
| include: "#comment" | |||
| } | |||
| ] | |||
| "checked-unchecked-statement": | |||
There was a problem hiding this comment.
this removed the definition of checked-unchecked-statement however it is still referenced:
this is breaking my more-strict tmlanguage parsing in https://github.com/asottile/babi-grammars:
Traceback (most recent call last):
File "/tmp/babi-grammars/bin/test-grammars", line 73, in <module>
raise SystemExit(main())
^^^^^^
File "/tmp/babi-grammars/bin/test-grammars", line 47, in main
compiler = grammars.compiler_for_file(filename, line)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/tmp/babi-grammars/.tox/py312/lib/python3.12/site-packages/babi/highlight.py", line 714, in compiler_for_file
return self.compiler_for_scope(scope)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/tmp/babi-grammars/.tox/py312/lib/python3.12/site-packages/babi/highlight.py", line 689, in compiler_for_scope
ret = self._compiled[scope] = Compiler(grammar, self)
^^^^^^^^^^^^^^^^^^^^^^^
File "/tmp/babi-grammars/.tox/py312/lib/python3.12/site-packages/babi/highlight.py", line 528, in __init__
root = self._compile_root(grammar)
^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/tmp/babi-grammars/.tox/py312/lib/python3.12/site-packages/babi/highlight.py", line 592, in _compile_root
regs, rules = self._patterns(grammar, grammar.patterns)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/tmp/babi-grammars/.tox/py312/lib/python3.12/site-packages/babi/highlight.py", line 565, in _patterns_
tmp_regs, tmp_rules = self._include(
^^^^^^^^^^^^^^
File "/tmp/babi-grammars/.tox/py312/lib/python3.12/site-packages/babi/highlight.py", line 547, in _include_
return self._patterns(grammar, (repository[s[1:]],))
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/tmp/babi-grammars/.tox/py312/lib/python3.12/site-packages/babi/highlight.py", line 571, in _patterns_
tmp_regs, tmp_rules = self._patterns(grammar, rule.patterns)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/tmp/babi-grammars/.tox/py312/lib/python3.12/site-packages/babi/highlight.py", line 565, in _patterns_
tmp_regs, tmp_rules = self._include(
^^^^^^^^^^^^^^
File "/tmp/babi-grammars/.tox/py312/lib/python3.12/site-packages/babi/highlight.py", line 547, in _include_
return self._patterns(grammar, (repository[s[1:]],))
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/tmp/babi-grammars/.tox/py312/lib/python3.12/site-packages/babi/highlight.py", line 571, in _patterns_
tmp_regs, tmp_rules = self._patterns(grammar, rule.patterns)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/tmp/babi-grammars/.tox/py312/lib/python3.12/site-packages/babi/highlight.py", line 565, in _patterns_
tmp_regs, tmp_rules = self._include(
^^^^^^^^^^^^^^
File "/tmp/babi-grammars/.tox/py312/lib/python3.12/site-packages/babi/highlight.py", line 547, in _include_
return self._patterns(grammar, (repository[s[1:]],))
~~~~~~~~~~^^^^^^^
File "/tmp/babi-grammars/.tox/py312/lib/python3.12/site-packages/babi/fdict.py", line 45, in __getitem__
raise KeyError(key)
KeyError: 'checked-unchecked-statement'There was a problem hiding this comment.
Good catch. Opened #298 to remove this reference.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is not a complete support for unsafe code, since there are many patterns detecting for type that do not support the * operator yet.
This PR only adds the missing keywords + minimal support for pointer type declaration.