Clarify that a copy constructor doesn't prevent an automatic addition of a default instance constructor for a record. #3913
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge from dotnet/csharplang
Merge from dotnet/csharplang
Merge from dotnet/csharplang
… of a default instance constructor for a record.
AlekseyTs
requested review from
333fred,
RikkiGibson,
MadsTorgersen and
jcouv
RikkiGibson
reviewed
Sep 18, 2020
| fields implicitly or explicitly declared within the record type. | ||
| fields implicitly or explicitly declared within the record type. | ||
| The sole presence of a copy constructor, whether explicit or implicit, doesn't prevent an automatic | ||
| addition of a default instance constructor. |
There was a problem hiding this comment.
Is a "default instance constructor" similar to what is synthesized for an empty class declaration class C { }?
There was a problem hiding this comment.
Is a "default instance constructor" similar to what is synthesized for an empty class declaration class C { }?
It isn't similar, it is what is synthesized for an empty class declaration.
jcouv
approved these changes
Sep 18, 2020
AlekseyTs
added a commit
to AlekseyTs/roslyn
that referenced
this pull request
Sep 18, 2020
…lt instance constructor for a record. dotnet/csharplang#3913
RikkiGibson
approved these changes
Sep 18, 2020
333fred
approved these changes
Sep 18, 2020
AlekseyTs
added a commit
to dotnet/roslyn
that referenced
this pull request
Sep 21, 2020
…lt instance constructor for a record. (#47850) dotnet/csharplang#3913
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.