Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update list-patterns.md #4860

Merged
merged 3 commits into from
Jun 22, 2021
Merged

Update list-patterns.md #4860

merged 3 commits into from
Jun 22, 2021

Conversation

alrz
Copy link
Member

@alrz alrz commented Jun 22, 2021

Finalized in LDM 2021-06-21

Test plan: dotnet/roslyn#51289

@alrz alrz requested a review from a team as a code owner June 22, 2021 12:59
333fred
333fred approved these changes Jun 22, 2021
View reviewed changes
Copy link
Member

@333fred 333fred left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jcouv, can you take a look as well?

@jcouv jcouv self-assigned this Jun 22, 2021
jcouv
jcouv approved these changes Jun 22, 2021
View reviewed changes
Copy link
Member

@jcouv jcouv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks (iteration 3)

@jcouv jcouv merged commit e4edc94 into dotnet:main Jun 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcouv jcouv jcouv approved these changes

@333fred 333fred 333fred approved these changes

Assignees

@jcouv jcouv

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alrz @333fred @jcouv