Rename LifetimeAnnotationAttribute to ScopedRefAttribute and remove unnecessary members
#6325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ve unnecessary members
|
@cston for review |
cston
reviewed
Jul 27, 2022
| ### LifetimeAnnotationAttribute | ||
| The `scoped` and `unscoped` annotations will be emitted into metadata via the type `System.Runtime.CompilerServices.LifetimeAttribute` attribute. This attribute will be matched by name meaning it does not need to appear in any specific assembly. | ||
| ### ScopedRefAttribute | ||
| The `scoped` and `unscoped` annotations will be emitted into metadata via the type `System.Runtime.CompilerServices.ScopedRefAttribute` attribute. This attribute will be matched by name meaning it does not need to appear in any specific assembly. |
cston
reviewed
Jul 27, 2022
| } | ||
| } | ||
| ``` | ||
|
|
||
| The attribute uses `int` instead of `bool` to allow for future lifetime expansions in this space. | ||
|
|
||
| The compiler will emit this attribute on the element targeted by the `scoped` or `unscoped` syntax. This is true for types, methods and parameters. This will only be emitted when the syntax causes the value to differ from its default state. For example `scoped out` will cause no attribute to be emitted. | ||
| The compiler will emit this attribute on the element targeted by the `scoped` syntax. This is true for types, methods and parameters. This will only be emitted when the syntax causes the value to differ from its default state. For example `scoped out` will cause no attribute to be emitted. |
There was a problem hiding this comment.
The compiler will emit this attribute on the element targeted by the
scopedsyntax. This is true for types, methods and parameters.
The second sentence is incorrect since this only applies to parameters. Perhaps change the first two sentences to: "The compiler will emit this attribute on the scoped parameter."
cston
reviewed
Jul 27, 2022
|
|
||
| public LifetimeAnnotationAttribute(int value) | ||
| [AttributeUsage(AttributeTargets.Parameter, AllowMultiple = false, Inherited = false)] | ||
| public sealed class ScopedRefAttribute : Attribute |
cston
reviewed
Jul 27, 2022
| } | ||
| } | ||
| ``` | ||
|
|
||
| The attribute uses `int` instead of `bool` to allow for future lifetime expansions in this space. | ||
|
|
||
| The compiler will emit this attribute on the element targeted by the `scoped` or `unscoped` syntax. This is true for types, methods and parameters. This will only be emitted when the syntax causes the value to differ from its default state. For example `scoped out` will cause no attribute to be emitted. |
cston
approved these changes
Jul 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to issue dotnet/roslyn#62838