Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add lambda params proposal #6542

Merged
merged 19 commits into from
Oct 20, 2022
Merged

Add lambda params proposal #6542

merged 19 commits into from
Oct 20, 2022

Conversation

jjonescz
Copy link
Member

@jjonescz jjonescz commented Oct 13, 2022 •
edited by jcouv
Loading

Relates to test plan dotnet/roslyn#62485

@jjonescz jjonescz requested a review from a team as a code owner October 13, 2022 13:57
333fred
333fred reviewed Oct 13, 2022
View reviewed changes
proposals/lambda-method-group-defaults.md Outdated Show resolved Hide resolved
proposals/lambda-method-group-defaults.md Outdated Show resolved Hide resolved
proposals/lambda-method-group-defaults.md Outdated Show resolved Hide resolved
jcouv
jcouv reviewed Oct 13, 2022
View reviewed changes
Copy link
Member

@jcouv jcouv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done with review pass (iteration 1)

@jcouv jcouv self-assigned this Oct 13, 2022
jcouv
jcouv approved these changes Oct 14, 2022
View reviewed changes
Copy link
Member

@jcouv jcouv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks (iteration 15)

@jjonescz jjonescz requested a review from cston October 17, 2022 09:22
@jjonescz jjonescz requested a review from jaredpar October 19, 2022 08:33
jcouv
jcouv approved these changes Oct 19, 2022
View reviewed changes
Copy link
Member

@jcouv jcouv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks (iteration 19)

@jjonescz jjonescz merged commit 4f2eca7 into dotnet:main Oct 20, 2022
@jjonescz jjonescz deleted the lambda-params-array branch October 20, 2022 07:11
@jjonescz jjonescz mentioned this pull request Oct 25, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaredpar jaredpar jaredpar approved these changes

@333fred 333fred 333fred approved these changes

@cston cston cston approved these changes

@jcouv jcouv jcouv approved these changes

Assignees

@jcouv jcouv

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jjonescz @jaredpar @333fred @cston @jcouv