Collection expressions: better conversion from element #8338
+36
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
333fred
reviewed
Aug 6, 2024
Comment on lines
+24
to
+25
| > * `T₁` is `System.ReadOnlySpan<E₁>`, and `T₂` is `System.Span<E₂>`, and an ~~implicit~~ **identity** conversion exists from `E₁` to `E₂` | ||
| > * `T₁` is `System.ReadOnlySpan<E₁>` or `System.Span<E₁>`, and `T₂` is an *array_or_array_interface* with *element type* `E₂`, and an ~~implicit~~ **identity** conversion exists from `E₁` to `E₂` |
There was a problem hiding this comment.
Mentioned this offline as well, but I'm not a fan of this change. Between ReadOnlySpan<string> and Span<object>, it feels like ReadOnlySpan<string> is clearly the better choice for a collection expression. Particularly since between ReadOnlySpan<object> and ReadOnlySpan<string>, the rule we're adding would make that unambiguous.
Think the next step here is to collect various examples of what we want to enable, vs what harm we think will come from leaving this overly broad. For example, the ReadOnlySpan<byte> vs Span<int> question.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update better conversion from expression to prefer the target with the better conversion from each element.
See LDM-2024-07-24