Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change block/statement/expression body not to be definitions #1019

Merged
merged 1 commit into from
Nov 30, 2023

Conversation

jskeet
Copy link
Contributor

@jskeet jskeet commented Nov 30, 2023

This is half of what #999 was trying to do; the rest requires some more work.

Fixes #948.

Bill: I believe we decided yesterday that this is fine, so let's just merge when you've checked that I haven't done anything silly.

This is half of what dotnet#999 was trying to do; the rest requires some
more work.
Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jskeet

This looks like what we agreed to, so I'll :shipit: now.

@BillWagner BillWagner merged commit 04e8816 into dotnet:draft-v8 Nov 30, 2023
7 checks passed
@jskeet jskeet deleted the remove-body-definitions branch January 8, 2024 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Word converter warnings
2 participants