Performed Copyediting for Minor Typos #1167
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
September 2, 2024 13:22
|
@dotnet-policy-service agree
…On Mon, Sep 2, 2024 at 2:01 PM dotnet-policy-service[bot] < ***@***.***> wrote:
@danielparvin <https://github.com/danielparvin> please read the following
Contributor License Agreement(CLA). If you agree with the CLA, please reply
with the following information.
@dotnet-policy-service agree [company="{your company}"]
Options:
- (default - no company specified) I have sole ownership of
intellectual property rights to my Submissions and I am not making
Submissions in the course of work for my employer.
@dotnet-policy-service agree
- (when company given) I am making Submissions in the course of work
for my employer (or my employer has intellectual property rights in my
Submissions by contract or applicable law). I have permission from my
employer to make Submissions and enter into this Agreement on behalf of my
employer. By signing below, the defined term “You” includes me and my
employer.
@dotnet-policy-service agree company="Microsoft"
Contributor License Agreement Contribution License Agreement
This Contribution License Agreement ( *“Agreement”* ) is agreed to by the
party signing below ( *“You”* ),
and conveys certain license rights to the .NET Foundation ( *“.NET
Foundation”* ) for Your contributions to
.NET Foundation open source projects. This Agreement is effective as of
the latest signature date below.
*1. Definitions.*
*“Code”* means the computer software code, whether in human-readable or
machine-executable form,
that is delivered by You to .NET Foundation under this Agreement.
*“Project”* means any of the projects owned or managed by .NET Foundation
and offered under a license
approved by the Open Source Initiative (www.opensource.org).
*“Submit”* is the act of uploading, submitting, transmitting, or
distributing code or other content to any
Project, including but not limited to communication on electronic mailing
lists, source code control
systems, and issue tracking systems that are managed by, or on behalf of,
the Project for the purpose of
discussing and improving that Project, but excluding communication that is
conspicuously marked or
otherwise designated in writing by You as “Not a Submission.”
*“Submission”* means the Code and any other copyrightable material
Submitted by You, including any
associated comments and documentation.
*2. Your Submission.* You must agree to the terms of this Agreement
before making a Submission to any
Project. This Agreement covers any and all Submissions that You, now or in
the future (except as
described in Section 4 below), Submit to any Project.
*3. Originality of Work.* You represent that each of Your Submissions is
entirely Your
original work. Should You wish to Submit materials that are not Your
original work,
You may Submit them separately to the Project if You (a) retain all
copyright and
license information that was in the materials as you received them, (b) in
the
description accompanying your Submission, include the phrase "Submission
containing materials of a third party:" followed by the names of the third
party and any
licenses or other restrictions of which You are aware, and (c) follow any
other
instructions in the Project's written guidelines concerning Submissions.
*4. Your Employer.* References to “employer” in this Agreement include
Your employer or anyone else
for whom You are acting in making Your Submission, e.g. as a contractor,
vendor, or agent. If Your
Submission is made in the course of Your work for an employer or Your
employer has intellectual
property rights in Your Submission by contract or applicable law, You must
secure permission from Your
employer to make the Submission before signing this Agreement. In that
case, the term “You” in this
Agreement will refer to You and the employer collectively. If You change
employers in the future and
desire to Submit additional Submissions for the new employer, then You
agree to sign a new Agreement
and secure permission from the new employer before Submitting those
Submissions.
*5. Licenses.*
*a. Copyright License.* You grant .NET Foundation, and those who receive
the Submission directly
or indirectly from .NET Foundation, a perpetual, worldwide, non-exclusive,
royalty-free, irrevocable
license in the Submission to reproduce, prepare derivative works of,
publicly display, publicly perform,
and distribute the Submission and such derivative works, and to sublicense
any or all of the foregoing
rights to third parties.
*b. Patent License.* You grant .NET Foundation, and those who receive the
Submission directly or
indirectly from .NET Foundation, a perpetual, worldwide, non-exclusive,
royalty-free, irrevocable license
under Your patent claims that are necessarily infringed by the Submission
or the combination of the
Submission with the Project to which it was Submitted to make, have made,
use, offer to sell, sell and
import or otherwise dispose of the Submission alone or with the Project.
*c. Other Rights Reserved.* Each party reserves all rights not expressly
granted in this Agreement.
No additional licenses or rights whatsoever (including, without
limitation, any implied licenses) are
granted by implication, exhaustion, estoppel or otherwise.
*6. Representations and Warranties.* You represent that You are legally
entitled to grant the above
licenses. You represent that each of Your Submissions is entirely Your
original work (except as You may
have disclosed under Section 3 ). You represent that You have secured
permission from Your employer to
make the Submission in cases where Your Submission is made in the course
of Your work for Your
employer or Your employer has intellectual property rights in Your
Submission by contract or applicable
law. If You are signing this Agreement on behalf of Your employer, You
represent and warrant that You
have the necessary authority to bind the listed employer to the
obligations contained in this Agreement.
You are not expected to provide support for Your Submission, unless You
choose to do so. UNLESS
REQUIRED BY APPLICABLE LAW OR AGREED TO IN WRITING, AND EXCEPT FOR THE
WARRANTIES
EXPRESSLY STATED IN SECTIONS 3, 4, AND 6 , THE SUBMISSION PROVIDED UNDER
THIS AGREEMENT IS
PROVIDED WITHOUT WARRANTY OF ANY KIND, INCLUDING, BUT NOT LIMITED TO, ANY
WARRANTY OF
NONINFRINGEMENT, MERCHANTABILITY, OR FITNESS FOR A PARTICULAR PURPOSE.
*7. Notice to .NET Foundation.* You agree to notify .NET Foundation in
writing of any facts or
circumstances of which You later become aware that would make Your
representations in this
Agreement inaccurate in any respect.
*8. Information about Submissions.* You agree that contributions to
Projects and information about
contributions may be maintained indefinitely and disclosed publicly,
including Your name and other
information that You submit with Your Submission.
*9. Governing Law/Jurisdiction.* This Agreement is governed by the laws
of the State of Washington, and
the parties consent to exclusive jurisdiction and venue in the federal
courts sitting in King County,
Washington, unless no federal subject matter jurisdiction exists, in which
case the parties consent to
exclusive jurisdiction and venue in the Superior Court of King County,
Washington. The parties waive all
defenses of lack of personal jurisdiction and forum non-conveniens.
*10. Entire Agreement/Assignment.* This Agreement is the entire agreement
between the parties, and
supersedes any and all prior agreements, understandings or communications,
written or oral, between
the parties relating to the subject matter hereof. This Agreement may be
assigned by .NET Foundation.
*.NET Foundation dedicates this Contribution License Agreement to the
public domain according to the Creative Commons CC0 1.*
—
Reply to this email directly, view it on GitHub
<#1167 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ADGNLCEKSGSTK5RRW2OOFJLZUSYYDAVCNFSM6AAAAABNQY5ZDOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMRVGIYTAMRTGM>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
--
(224)465-8085
|
Nigel-Ecma
requested changes
Sep 15, 2024
There was a problem hiding this comment.
Well spotted, thanks!
Most of the English grammar ones look good however I will leave @RexJaeschke to check them. The typo fixes all look correct. The stylistic use of en/em-dash and escapes I'll defer to Rex again.
Unfortunately the C# grammar change is wrong and needs to be removed.
standard/classes.md
Outdated
| @@ -4460,7 +4460,7 @@ binary_operator_declarator | |||
|
|
|||
| overloadable_binary_operator | |||
| : '+' | '-' | '*' | '/' | '%' | '&' | '|' | '^' | '<<' | |||
| | right_shift | '==' | '!=' | '>' | '<' | '>=' | '<=' | |||
There was a problem hiding this comment.
This change is wrong. The right_shift production exists to resolve a syntactic ambiguity in C#.
Comment on lines
-705
to
-706
| - If a standard implicit conversion ([§10.4.2](conversions.md#1042-standard-implicit-conversions)) exists from a type `A` to a type `B`, and if neither `A` nor `B` are *interface_type* `s`, then `A` is said to be ***encompassed by*** `B`, and `B` is said to ***encompass*** `A`. | ||
| - If a standard implicit conversion ([§10.4.2](conversions.md#1042-standard-implicit-conversions)) exists from an expression `E` to a type `B`, and if neither `B` nor the type of `E` (if it has one) are *interface_type* `s`, then `E` is said to be *encompassed by* `B`, and `B` is said to *encompass* `E`. |
There was a problem hiding this comment.
The s here was intended to indicate a plural, I think; not a type whose name is s. That is, A is not an interface_type and B is also not an interface_type.
standard/expressions.md
Outdated
| > | [§12.13](expressions.md#1213-logical-operators) | Logical OR | `\|` | | ||
| > | [§12.13](expressions.md#1213-logical-operators) | Logical OR | <code>|</code> | |
There was a problem hiding this comment.
This change looks OK for Markdown but will the automatic conversion to Word handle the syntax right?
There was a problem hiding this comment.
It will not! Leave this as it was.
standard/delegates.md
Outdated
| C# provides special syntax for invoking a delegate. When a non-`null` delegate instance whose invocation list contains one entry, is invoked, it invokes the one method with the same arguments it was given, and returns the same value as the referred to method. (See [§12.8.9.4](expressions.md#12894-delegate-invocations) for detailed information on delegate invocation.) If an exception occurs during the invocation of such a delegate, and that exception is not caught within the method that was invoked, the search for an exception catch clause continues in the method that called the delegate, as if that method had directly called the method to which that delegate referred. | ||
| C# provides special syntax for invoking a delegate. When a non-`null` delegate instance whose invocation list contains one entry is invoked, it invokes the one method with the same arguments it was given and returns the same value as the referred-to method. (See [§12.8.9.4](expressions.md#12894-delegate-invocations) for detailed information on delegate invocation.) If an exception occurs during the invocation of such a delegate, and that exception is not caught within the method that was invoked, the search for an exception catch clause continues in the method that called the delegate, as if that method had directly called the method to which that delegate referred. |
There was a problem hiding this comment.
Here too, I'd prefer keeping the commas.
There was a problem hiding this comment.
Thank you. Please take a look at the newest commit and let me know what you think. I really dislike the first comma, but have added the second comma back in.
RexJaeschke
reviewed
Sep 16, 2024
standard/classes.md
Outdated
| @@ -3780,7 +3780,7 @@ Once a particular non-ref-valued property or non-ref-valued indexer has been sel | |||
| > | |||
| > *end example* | |||
|
|
|||
| Once a particular ref-valued property or ref-valued indexer has been selected; whether the usage is as a value, the target of a simple assignment, or the target of a compound assignment; the accessibility domain of the get accessor involved is used to determine if that usage is valid. | |||
| Once a particular ref-valued property or ref-valued indexer has been selected--whether the usage is as a value, the target of a simple assignment, or the target of a compound assignment--the accessibility domain of the get accessor involved is used to determine if that usage is valid. | |||
There was a problem hiding this comment.
Make these em-dashes (---).
RexJaeschke
reviewed
Sep 16, 2024
standard/expressions.md
Outdated
| > | [§12.14](expressions.md#1214-conditional-logical-operators) | Conditional AND | `&&` | | ||
| > | [§12.14](expressions.md#1214-conditional-logical-operators) | Conditional OR | `\|\|` | | ||
| > | [§12.14](expressions.md#1214-conditional-logical-operators) | Conditional OR | <code>||</code> | |
RexJaeschke
reviewed
Sep 16, 2024
standard/expressions.md
Outdated
Comment on lines
2525
to
2526
| > *Example*: | ||
| > The following shows a class that represents a contact with a name and a list of phone numbers, and the creation and initialization of a `List<Contact>`: |
There was a problem hiding this comment.
Revert to original and put a space after the first colon. We want this to be a single quotation, not two!
|
@danielparvin I just added my feedback as comments. I am quite new to the PR-reviewing process, and now that I'm done I just learned I could have turned my prose into specific code edits. C'est la vie! |
danielparvin
requested review from
RexJaeschke,
Nigel-Ecma and
KalleOlaviNiemitalo
Nigel-Ecma
reviewed
Sep 23, 2024
There was a problem hiding this comment.
One comment, will defer to @RexJaeschke on that, otherwise LGTM
standard/expressions.md
Outdated
| - for an `in`, `out`, or `ref` parameter, the type of the argument expression is identical to the type of the corresponding parameter. | ||
| - the parameter-passing mode of the argument is value, and the parameter-passing mode of the corresponding parameter is input, and an implicit conversion ([§10.2](conversions.md#102-implicit-conversions)) exists from the argument expression to the type of the corresponding parameter. | ||
| - for a by-reference parameter, the type of the argument expression is identical to the type of the corresponding parameter. | ||
| - the parameter-passing mode of the argument is value, and the parameter-passing mode of the corresponding parameter is input, and an implicit conversion ([§10.2](conversions.md#102-implicit-conversions)) exists from the argument expression to the type of the corresponding parameter |
There was a problem hiding this comment.
I think the last bullet should retain its full-stop. For the innermost list on 1020-22 I’d also introduce with a colon (“and:” on 1020) and seperate with a semi-colon (“parameter; or” on 1021). But will defer to @RexJaeschke on these.
There was a problem hiding this comment.
@Nigel-Ecma , those changes make sense to me; thank you!
RexJaeschke
approved these changes
Oct 3, 2024
Nigel-Ecma
requested changes
Oct 15, 2024
standard/expressions.md
Outdated
|
|
||
| When the implicit conversion from the argument type to the parameter type of an input parameter is a dynamic implicit conversion ([§10.2.10](conversions.md#10210-implicit-dynamic-conversions)), the results are undefined. | ||
| When the implicit conversion from the argument type to the parameter type of an `in` parameter is a dynamic implicit conversion ([§10.2.10](conversions.md#10210-implicit-dynamic-conversions)), the results are undefined. |
There was a problem hiding this comment.
The change “input” -> “in” is incorrect (similar issues have been fixed recently in #1172)
Suggested change
| When the implicit conversion from the argument type to the parameter type of an `in` parameter is a dynamic implicit conversion ([§10.2.10](conversions.md#10210-implicit-dynamic-conversions)), the results are undefined. | |
| When the implicit conversion from the argument type to the parameter type of an input parameter is a dynamic implicit conversion ([§10.2.10](conversions.md#10210-implicit-dynamic-conversions)), the results are undefined. |
There was a problem hiding this comment.
Ah, I wondered about that. Thanks for catching that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed various typos and minor formatting issues.