Skip to content

Commit

Permalink
Address remaining comments on proposal
Browse files Browse the repository at this point in the history
  • Loading branch information
terrajobst committed Mar 29, 2018
1 parent 040c376 commit e0fd363
Showing 1 changed file with 5 additions and 2 deletions.
7 changes: 5 additions & 2 deletions accepted/targeting-packs/targeting-packs.md
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,10 @@ Daniel has created a [prototype](https://github.com/dsplaisted/ReferenceAssembly

### Details

* We need to fix ASP.NET Core Razor compilation to locate reference assemblies
without their custom locater that assumes the only place to look for is the
global TP location.
- See [this bug for details](https://github.com/dotnet/sdk/issues/2054)
* There will be separate NuGet packages with reference assemblies for each
version of .NET Framework. This means that projects targeting a single version
of .NET Framework don't need to download and spend disk space on the reference
Expand Down Expand Up @@ -115,8 +119,7 @@ Daniel has created a [prototype](https://github.com/dsplaisted/ReferenceAssembly
* The logic in the `.targets` file in the NuGet packages will only set the
`TargetFrameworkRootPath` if the `TargetFrameworkIdentifier` and
`TargetFrameworkVersion` properties match the reference assemblies that the
package provides. It will also only set the property if the
`UseReferenceAssembliesFromPackage` property is set to true.
package provides.
* The reference assembly packages should include the `.xml` intellisense
documentation files. I believe the `.xml` documentation files have to be in
the same folder as the reference assemblies, so there isn't a way to deliver
Expand Down

0 comments on commit e0fd363

Please sign in to comment.