Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port cross oxs-arm64 build support from runtime #1642

Merged
merged 6 commits into from
Oct 10, 2020
Merged

Port cross oxs-arm64 build support from runtime #1642

merged 6 commits into from
Oct 10, 2020

Conversation

sdmaclea
Copy link
Contributor

@sdmaclea sdmaclea commented Oct 9, 2020

This backports @janvorli osx-arm64 cross building work in dotnet/runtime#40435

@sdmaclea sdmaclea added engineering arm64 ARM64 architecture related issue labels Oct 9, 2020
@sdmaclea sdmaclea added this to the 6.0 milestone Oct 9, 2020
@sdmaclea sdmaclea requested review from janvorli and hoyosjs October 9, 2020 20:10
@sdmaclea sdmaclea requested a review from a team as a code owner October 9, 2020 20:10
@sdmaclea sdmaclea self-assigned this Oct 9, 2020
janvorli
janvorli approved these changes Oct 9, 2020
View reviewed changes
Copy link
Member

@janvorli janvorli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@sdmaclea
Copy link
Contributor Author

/cc @dotnet/dotnet-diag This needs a diag team review before it can be merged.

hoyosjs
hoyosjs approved these changes Oct 10, 2020
View reviewed changes
Copy link
Member

@hoyosjs hoyosjs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. Glanced quickly through the time changes given I'm no expert and they look fine.

eng/build.yml Outdated Show resolved Hide resolved
@sdmaclea sdmaclea merged commit fb8b6fc into dotnet:master Oct 10, 2020
@sdmaclea sdmaclea deleted the crossOsxArm64 branch June 10, 2021 00:35
@github-actions github-actions bot locked and limited conversation to collaborators Jan 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@hoyosjs hoyosjs hoyosjs approved these changes

@janvorli janvorli janvorli approved these changes

Assignees

@sdmaclea sdmaclea

Labels
arm64 ARM64 architecture related issue engineering
Projects
None yet
Milestone
6.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@sdmaclea @janvorli @hoyosjs