ApplyStartupHook diagnostic IPC command #3918
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davmason
approved these changes
May 31, 2023
Contributor
davmason
left a comment
davmason
left a comment
There was a problem hiding this comment.
Just the one thing and it looks good to me.
Contributor
|
@jander-msft are you waiting for the design to be approved before working on the runtime side, or did I miss a PR? |
Contributor
Author
I'm actively working on it here: https://github.com/dotnet/runtime/pull/86813/files. Please provide any feedback you feel necessary. The intent is that the startup hook is cached during startup diagnostic suspension and applied when resumed; a follow up PR will enable automatically applying and executing the startup hook when managed code is already running. |
jander-msft
force-pushed
the
applystartuphook
branch
from
1fc1d91 to
5de35f5
Compare
Contributor
Author
|
/azp run diagnostics-public-ci |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes add a new command that provides the .NET runtime a path to a managed assembly that contains a startup hook. Issuing this command during diagnostic suspension would be similar to prepending the path to the
DOTNET_STARTUP_HOOKSenvironment variable before launching the target process.Corresponding runtime change: dotnet/runtime#86813
cc @dotnet/dotnet-monitor