Skip to content

Conversation

@adamsitnik
Copy link
Member

I am currently working on updating all the repos that are part of VMR to latest version of System.CommandLine.

To tell the long story short, we want to release new S.CL, but also remove some parts like System.CommandLine.Rendering.

I am pretty confident about my changes related to all the tools (first commit), but Microsoft.Diagnostics.DebugServices.Implementation work (2nd commit) will most likely need more work from my side.

Since I am about to start my weekend I am opening this PR to at least get some initial feedback about the direction (so I know what to do on Monday).

@adamsitnik adamsitnik requested a review from a team as a code owner January 31, 2025 16:33
@mikem8361
Copy link
Contributor

I'm looking at the test failures. It may take me a while.

@mikem8361
Copy link
Contributor

If you are ready to merge, approve it (since I made some changes) and I'll merge it.

Copy link
Member Author

@adamsitnik adamsitnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mikem8361 big thanks for your help! Your changes LGTM!

Due to a circular dependency between NuGet.Client and SDK and the fact that NuGet.Client repo does not have a dedicated branches for .NET 9 and 10 (NuGet/NuGet.Client#6236), we have decided to postpone the updates in most of the repos that are part of VMR until April.

But, since only a small part of diagnostics repo is built as part of VMR:

<ProjectToBuild Include="$(RepoRoot)src/Microsoft.Diagnostics.NETCore.Client/Microsoft.Diagnostics.NETCore.Client.csproj" />

I believe that similarly to Aspire (dotnet/aspire#7385), this PR can be merged already.

cc @ViktorHofer

@mikem8361
Copy link
Contributor

@adamsitnik can you re-approve this PR?

@adamsitnik
Copy link
Member Author

@adamsitnik can you re-approve this PR?

I can't (the code LGTM, but the UI does not let me to). Can you merge without my approval?

{11F644E3-126B-4FF7-A180-EACEFBAA0544}

@mikem8361 mikem8361 merged commit 6837b8f into dotnet:main Feb 11, 2025
20 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Mar 14, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants