-
Notifications
You must be signed in to change notification settings - Fork 383
Update System.CommandLine version #5217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…likely it's going to require some extra work to get it to work as expected)
src/Microsoft.Diagnostics.DebugServices.Implementation/CommandService.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Diagnostics.DebugServices.Implementation/CommandService.cs
Show resolved
Hide resolved
|
I'm looking at the test failures. It may take me a while. |
|
If you are ready to merge, approve it (since I made some changes) and I'll merge it. |
adamsitnik
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mikem8361 big thanks for your help! Your changes LGTM!
Due to a circular dependency between NuGet.Client and SDK and the fact that NuGet.Client repo does not have a dedicated branches for .NET 9 and 10 (NuGet/NuGet.Client#6236), we have decided to postpone the updates in most of the repos that are part of VMR until April.
But, since only a small part of diagnostics repo is built as part of VMR:
diagnostics/eng/DotNetBuild.props
Line 11 in 1fdb547
| <ProjectToBuild Include="$(RepoRoot)src/Microsoft.Diagnostics.NETCore.Client/Microsoft.Diagnostics.NETCore.Client.csproj" /> |
I believe that similarly to Aspire (dotnet/aspire#7385), this PR can be merged already.
cc @ViktorHofer
|
@adamsitnik can you re-approve this PR? |
I can't (the code LGTM, but the UI does not let me to). Can you merge without my approval? |

I am currently working on updating all the repos that are part of VMR to latest version of System.CommandLine.
To tell the long story short, we want to release new S.CL, but also remove some parts like System.CommandLine.Rendering.
I am pretty confident about my changes related to all the tools (first commit), but Microsoft.Diagnostics.DebugServices.Implementation work (2nd commit) will most likely need more work from my side.
Since I am about to start my weekend I am opening this PR to at least get some initial feedback about the direction (so I know what to do on Monday).