Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Fix Node.js prerequisite issues #10406

Merged
merged 1 commit into from
Nov 20, 2024

Conversation

filzrev
Copy link
Contributor

@filzrev filzrev commented Nov 19, 2024

This PR intend to fix issue that reported on following comment.

By change PlaywrightHelper.EnsurePlaywrightNodeJsPath initialization timing.
And add following paragraph to Prerequisites section

(Optional: It's required when using Create PDF Files)

@yufeih yufeih merged commit 5dce25b into dotnet:main Nov 20, 2024
7 checks passed
@yufeih yufeih added the bug-fix Makes the pull request to appear in "Bug Fixes" section of the next release note label Nov 20, 2024
@brettnf
Copy link

brettnf commented Nov 20, 2024

@yufeih can you please create a new release with this fix? we need this update asap

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug-fix Makes the pull request to appear in "Bug Fixes" section of the next release note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants