Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add icon to external links #8523

Merged
merged 3 commits into from
Mar 19, 2023
Merged

feat: add icon to external links #8523

merged 3 commits into from
Mar 19, 2023

Conversation

yufeih
Copy link
Contributor

@yufeih yufeih commented Mar 18, 2023

Makes external links open in new tabs for modern template, with an icon hint.

#2298

@codecov
Copy link

codecov bot commented Mar 18, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.01 ⚠️

Comparison is base (dc83d83) 76.30% compared to head (8027a33) 76.30%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8523      +/-   ##
==========================================
- Coverage   76.30%   76.30%   -0.01%     
==========================================
  Files         858      858              
  Lines       30639    30639              
==========================================
- Hits        23380    23378       -2     
- Misses       7259     7261       +2     

see 2 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@yufeih yufeih marked this pull request as ready for review March 19, 2023 01:41
@yufeih yufeih closed this Mar 19, 2023
@yufeih yufeih reopened this Mar 19, 2023
@yufeih yufeih merged commit f5dc181 into main Mar 19, 2023
@yufeih yufeih deleted the external-link branch March 19, 2023 06:58
@yufeih yufeih added the new-feature Makes the pull request to appear in "New Features" section of the next release note label Mar 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-feature Makes the pull request to appear in "New Features" section of the next release note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants