Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Cleanup tests and fix spellings #9091

Merged
merged 1 commit into from
Aug 17, 2023

Conversation

filzrev
Copy link
Contributor

@filzrev filzrev commented Aug 17, 2023

What's included in this PR

  • Fix spelling miss in verbose log message from week type to `weak type".
  • Remove code that explicitly setting ServicePointManager.SecurityProtocol to Tls12
    Because there are no supported OS/.NET versions that require this settings.
  • Remove TestSchemaReachedLimits tests. Because Json.NET schema is not used anymore.
  • Rename test method signature and traits that using Markdig.
  • Modify skipped tests. that pass tests with small modifications.
  • Remove TestMetadataCommandFromCSProjectWithVsinstalldirEnvSet test because it's not actually used.

@codecov
Copy link

codecov bot commented Aug 17, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.01% ⚠️

Comparison is base (706a10c) 77.58% compared to head (b6f89b1) 77.58%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9091      +/-   ##
==========================================
- Coverage   77.58%   77.58%   -0.01%     
==========================================
  Files         592      592              
  Lines       24608    24608              
==========================================
- Hits        19092    19091       -1     
- Misses       5516     5517       +1     
Files Changed Coverage Δ
src/Docfx.Build.SchemaDriven/OverwriteApplier.cs 96.15% <ø> (ø)
src/Docfx.Build.Engine/ManifestProcessor.cs 94.53% <100.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@yufeih yufeih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@yufeih yufeih added the engineering Makes the pull request to appear in the "Engineering" section of the next release note label Aug 17, 2023
@yufeih yufeih merged commit f698eac into dotnet:main Aug 17, 2023
7 checks passed
@filzrev filzrev deleted the chore-cleanup-tests-and-fix-spelling branch August 24, 2023 02:46
p-kostov pushed a commit to ErpNetDocs/docfx that referenced this pull request Jun 28, 2024
chore: cleanup tests and fix spellings
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
engineering Makes the pull request to appear in the "Engineering" section of the next release note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants