Remove support for DockerfileGitCommitSha and TimeStamp system variables #1399
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
ghost
added
the
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
MichaelSimons
commented
Aug 15, 2024
| } | ||
| else | ||
| { | ||
| variableValue = Options.GetOption(variableName); |
Member
Author
There was a problem hiding this comment.
I didn't find a usage of system variables being specified as an option. Not 100% certain though.
Member
There was a problem hiding this comment.
Yeah, I don't see any usage of it either.
mthalman
approved these changes
Aug 15, 2024
Member
Author
|
Waiting to merge until dotnet/dotnet-buildtools-prereqs-docker#1178 goes in. |
sbomer
added a commit
to sbomer/docker-tools
that referenced
this pull request
Mar 4, 2025
…m variables (dotnet#1399)" This reverts commit df4c6ca.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1398