Handle non-matching tag names between manifest and image info file #693
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In cases where a dynamically named tag is defined in the manifest, such as with the use of
$(System:TimeStamp), there's likely to be discrepancies in the tag names between the manifest and the tag names defined in the image info file that was generated during the build. The logic inCopyAcrImagesCommanddoesn't handle this and explicitly expects there to be a matching tag name. When it can't find one, an exception occurs.I've updated the logic to gracefully handle this scenario by simply ignoring the fact that it couldn't find a match and not attempt to process the syndication data. I think it's fine to say that, for now, syndication won't be supported for such dynamically named tags. I do think this could eventually be supported with the manifest redesign by allowing tags to have statically defined identifiers.
Fixes #686