Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Azure Postgres Flexible Server specific deployment article. #428

Closed
mitchdenny opened this issue Feb 25, 2024 · 2 comments · Fixed by #1046
Closed

Make Azure Postgres Flexible Server specific deployment article. #428

mitchdenny opened this issue Feb 25, 2024 · 2 comments · Fixed by #1046
Assignees
Labels
docs-experience Indicates issues that are about the learn.microsoft.com experience or design [org][type][category] documentation Improvements or additions to documentation general-availability Issues related to .NET Aspire going "GA". Pri1 High priority, do before Pri2 and Pri3

Comments

@mitchdenny
Copy link
Member

mitchdenny commented Feb 25, 2024

At the end of this article:

https://learn.microsoft.com/en-us/dotnet/aspire/database/postgresql-component?tabs=dotnet-cli

We should link on to a new article which describes how to deploy a .NET Aspire application with a Postgres database resource to Azure. We have a new API for this that generates Bicep that is used by AZD.

builder.AddPostgres("pgsql").PublishAsAzurePostgresFlexibleServer().AddDatabase(db);

Associated WorkItem - 238748

@dotnet-bot dotnet-bot added the ⌚ Not Triaged Not triaged label Feb 25, 2024
@IEvangelist IEvangelist added the preview-4 Used to track doc updates for preview 4 of .NET Aspire. label Feb 26, 2024
@IEvangelist
Copy link
Member

IEvangelist commented Mar 13, 2024

Hey @mitchdenny - is that code accurate?

I noticed that the db parameter in the AddDatabase call isn't a string, I'm assuming that's a typo.

Should that instead be:

builder.AddPostgres("pgsql")
       .PublishAsAzurePostgresFlexibleServer()
-      .AddDatabase(db);
+      .AddDatabase("db");

@mitchdenny
Copy link
Member Author

Yeah its a typo. Thanks!

@mitchdenny mitchdenny added preview-5 Used to track doc updates for preview 5 of .NET Aspire and removed preview-4 Used to track doc updates for preview 4 of .NET Aspire. labels Mar 28, 2024
@IEvangelist IEvangelist added documentation Improvements or additions to documentation 🗺️ reQUEST Triggers an issue to be imported into Quest. Pri1 High priority, do before Pri2 and Pri3 docs-experience Indicates issues that are about the learn.microsoft.com experience or design [org][type][category] labels Mar 28, 2024
@sequestor sequestor bot added 📌 seQUESTered Identifies that an issue has been imported into Quest. and removed 🗺️ reQUEST Triggers an issue to be imported into Quest. labels Mar 29, 2024
@IEvangelist IEvangelist removed the 📌 seQUESTered Identifies that an issue has been imported into Quest. label May 2, 2024
@IEvangelist IEvangelist added general-availability Issues related to .NET Aspire going "GA". and removed preview-5 Used to track doc updates for preview 5 of .NET Aspire labels May 13, 2024
@IEvangelist IEvangelist self-assigned this May 13, 2024
@IEvangelist IEvangelist removed the ⌚ Not Triaged Not triaged label May 13, 2024
IEvangelist added a commit to IEvangelist/docs-aspire that referenced this issue Jun 5, 2024
IEvangelist added a commit that referenced this issue Jun 6, 2024
* Ok, I got a little carried away, but these were missing. Also, fixes #428

* Added a few words about execution context

* Apply suggestions from code review

Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com>

* Apply suggestions from code review

---------

Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-experience Indicates issues that are about the learn.microsoft.com experience or design [org][type][category] documentation Improvements or additions to documentation general-availability Issues related to .NET Aspire going "GA". Pri1 High priority, do before Pri2 and Pri3
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants