Skip to content

Conversation

IEvangelist
Copy link
Member

@IEvangelist IEvangelist commented Jul 10, 2025

Summary

Update eventing documentation and code samples for .NET Aspire 9.4

Fixes #3909


Internal previews

📄 File 🔗 Preview link
docs/app-host/eventing.md Eventing in .NET Aspire

@IEvangelist IEvangelist requested review from adegeo and Copilot July 10, 2025 18:52
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Update eventing documentation and code samples for version 9.4 of .NET Aspire.

  • Bump package references and console snippet version numbers to 9.4.0.
  • Migrate resource event subscriptions to new On* extension methods.
  • Refresh eventing.md to reflect new event names, ordering, and code paths.

Reviewed Changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
docs/app-host/snippets/AspireApp/AspireApp.ResourceAppHost/Console.txt Update console output sample for resource event names and version
docs/app-host/snippets/AspireApp/AspireApp.ResourceAppHost/AspireApp.ResourceAppHost.csproj Bump package references to 9.4.0-preview
docs/app-host/snippets/AspireApp/AspireApp.ResourceAppHost/AppHost.cs Switch to On* extension methods for resource event subscriptions
docs/app-host/snippets/AspireApp/AspireApp.AppHost/Console.txt Update console output sample for app host event names and version
docs/app-host/snippets/AspireApp/AspireApp.AppHost/AspireApp.AppHost.csproj Bump package references to 9.4.0-preview
docs/app-host/snippets/AspireApp/AspireApp.AppHost/AppHost.cs Update subscription code for app host events
docs/app-host/eventing.md Refresh eventing docs with new event names, ordering, and paths
Comments suppressed due to low confidence (5)

docs/app-host/snippets/AspireApp/AspireApp.ResourceAppHost/Console.txt:13

  • Indent the info: Program[0] line with two spaces to match the surrounding console output format.
info: Program[0]

docs/app-host/snippets/AspireApp/AspireApp.AppHost/Console.txt:11

  • Add leading spaces before info: Program[0] so it aligns with other log lines in the console snippet.
info: Program[0]

docs/app-host/snippets/AspireApp/AspireApp.AppHost/Console.txt:13

  • Add leading spaces before info: Program[0] so it aligns with other log lines in the console snippet.
info: Program[0]

docs/app-host/snippets/AspireApp/AspireApp.AppHost/Console.txt:15

  • Add leading spaces before info: Program[0] so it aligns with other log lines in the console snippet.
info: Program[0]

docs/app-host/snippets/AspireApp/AspireApp.AppHost/AppHost.cs:17

  • The subscription for ResourceEndpointsAllocatedEvent was removed accidentally. You should restore or replace it (e.g. use Subscribe<ResourceEndpointsAllocatedEvent> or the appropriate OnResourceEndpointsAllocated extension) so that the app host logs endpoints allocation.
builder.Eventing.Subscribe<ResourceEndpointsAllocatedEvent>(

@IEvangelist IEvangelist merged commit e6941a3 into dotnet:release-9.4 Jul 10, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant