Skip to content

Conversation

IEvangelist
Copy link
Member

@IEvangelist IEvangelist commented Jul 11, 2025

Summary

Add details about how container networks are managed

Fixes #3933


Internal previews

📄 File 🔗 Preview link
docs/architecture/overview.md .NET Aspire architecture overview
docs/fundamentals/networking-overview.md .NET Aspire inner loop networking overview

@IEvangelist IEvangelist requested review from adegeo and Copilot July 11, 2025 13:52
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Adds detailed documentation on container network management and updates metadata dates

  • Introduces a new section in networking-overview.md describing how Aspire creates, names, and manages container bridge networks
  • Updates ms.date in both docs to reflect the July 11, 2025 changes
  • Adds a reference link in architecture/overview.md pointing to the new container networking section

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
docs/fundamentals/networking-overview.md Added "How container networks are managed" section and updated ms.date
docs/architecture/overview.md Bumped ms.date and inserted link to the new container networking docs

@davidfowl
Copy link
Member

cc @danegsta

@IEvangelist IEvangelist requested a review from danegsta July 11, 2025 13:57
Copy link
Contributor

@adegeo adegeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Minor thought on some wording.

Co-authored-by: Andy (Steve) De George <67293991+adegeo@users.noreply.github.com>
Copy link
Member

@danegsta danegsta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good; just to make sure, would these docs ship with 9.4? The behavior before 9.4 is different with regards to lifetimes and network naming.

@IEvangelist
Copy link
Member Author

Looks good; just to make sure, would these docs ship with 9.4? The behavior before 9.4 is different with regards to lifetimes and network naming.

Yes, this is intended to ship with the content updates for 9.4

@IEvangelist IEvangelist merged commit 8d34f89 into dotnet:release-9.4 Jul 11, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants