Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Foldable devices with .NET MAUI #1057

Merged
merged 16 commits into from
Nov 7, 2022
Merged

Foldable devices with .NET MAUI #1057

merged 16 commits into from
Nov 7, 2022

Conversation

conceptdev
Copy link
Contributor

@conceptdev conceptdev commented Nov 3, 2022 •
edited
Loading

@davidbritch I started a new branch and PR, wasn't paying attention and screwed up the earlier one

Docs for the Foldable .NET MAUI NuGet.

  • What is the right location in the TOC? Currently in Fundamentals but could belong in User Interface > Views ?
  • Whether to include DualScreenInfo?
  • Whether to include Triggers?
  • Should we keep the sample link to "github.com/conceptdev", remove the link, or move the sample to a Microsoft repo? moved to MS repo

Supersedes #956

@conceptdev conceptdev added 🏁 Release: .NET 9 Work items for the .NET 9 release do-not-merge labels Nov 3, 2022
@conceptdev conceptdev mentioned this pull request Nov 3, 2022
Closed
4 tasks
@conceptdev conceptdev marked this pull request as ready for review November 7, 2022 16:14
@conceptdev conceptdev changed the title [WIP] Foldable devices with .NET MAUI Foldable devices with .NET MAUI Nov 7, 2022
davidbritch
davidbritch requested changes Nov 7, 2022
View reviewed changes
docs/user-interface/controls/twopaneview.md Outdated Show resolved Hide resolved
docs/user-interface/controls/twopaneview.md Outdated Show resolved Hide resolved
docs/user-interface/controls/twopaneview.md Outdated Show resolved Hide resolved
docs/user-interface/controls/twopaneview.md Outdated Show resolved Hide resolved
docs/user-interface/controls/twopaneview.md Outdated Show resolved Hide resolved
docs/user-interface/controls/twopaneview.md Outdated Show resolved Hide resolved
docs/user-interface/controls/twopaneview.md Outdated Show resolved Hide resolved
docs/user-interface/controls/twopaneview.md Outdated Show resolved Hide resolved
docs/user-interface/controls/twopaneview.md Outdated Show resolved Hide resolved
conceptdev and others added 9 commits November 7, 2022 08:32
@conceptdev @davidbritch
Update docs/user-interface/controls/twopaneview.md
0126034 
Co-authored-by: David Britch <davidbritch@users.noreply.github.com>
@conceptdev @davidbritch
Update docs/user-interface/controls/twopaneview.md
26badec 
Co-authored-by: David Britch <davidbritch@users.noreply.github.com>
@conceptdev @davidbritch
Update docs/user-interface/controls/twopaneview.md
a8d79ae 
Co-authored-by: David Britch <davidbritch@users.noreply.github.com>
@conceptdev @davidbritch
Update docs/user-interface/controls/twopaneview.md
963d48b 
Co-authored-by: David Britch <davidbritch@users.noreply.github.com>
@conceptdev @davidbritch
Update docs/user-interface/controls/twopaneview.md
ef203b8 
Co-authored-by: David Britch <davidbritch@users.noreply.github.com>
@conceptdev @davidbritch
Update docs/user-interface/controls/twopaneview.md
cced32c 
Co-authored-by: David Britch <davidbritch@users.noreply.github.com>
@conceptdev @davidbritch
Update docs/user-interface/controls/twopaneview.md
5abc101 
Co-authored-by: David Britch <davidbritch@users.noreply.github.com>
@conceptdev @davidbritch
Update docs/user-interface/controls/twopaneview.md
8ecf8df 
Co-authored-by: David Britch <davidbritch@users.noreply.github.com>
@conceptdev
[foldable] impl review feedback
dba69a1
davidbritch
davidbritch requested changes Nov 7, 2022
View reviewed changes
docs/user-interface/controls/twopaneview.md Outdated Show resolved Hide resolved
docs/user-interface/controls/twopaneview.md Outdated Show resolved Hide resolved
docs/user-interface/controls/twopaneview.md Outdated Show resolved Hide resolved
conceptdev and others added 3 commits November 7, 2022 08:53
@conceptdev @davidbritch
Update docs/user-interface/controls/twopaneview.md
75168f9 
Co-authored-by: David Britch <davidbritch@users.noreply.github.com>
@conceptdev @davidbritch
Update docs/user-interface/controls/twopaneview.md
d1f6fad 
Co-authored-by: David Britch <davidbritch@users.noreply.github.com>
@conceptdev @davidbritch
Update docs/user-interface/controls/twopaneview.md
abea922 
Co-authored-by: David Britch <davidbritch@users.noreply.github.com>
@davidbritch davidbritch merged commit 1e52c03 into net7 Nov 7, 2022
@davidbritch davidbritch deleted the conceptdev-605-net7-foldable branch November 7, 2022 16:56
davidbritch added a commit that referenced this pull request Nov 8, 2022
@davidbritch @adegeo
@mahab339 @conceptdev
.NET 7 content (#1062)
52074c2 
* Maps (#926)

* Map.

* Fix broken links.

* Rename Essentials Map doc.

* Add to TOC.

* Moniker setup.

* Configure monikers.

* Fix range.

* Fix group config.

* Edits.

* Remove hard tabs.

* Remove hard tabs.

* Remove hard tabs.

* StrokeShape default is Rectangle in .NET 7 (#928)

* StrokeShape default changes from null to Rectangle in .NET 7.0

* Remove blank lines from UL.

* Move the text outside of the UL.

* App lifecycle updates (#960)

* .NET 7 iOS lifecycle additions.

* Fix tables.

* Edit.

* Edit.

* Remove monikers.

* Fix.

* Re-add table without scene kit.

* Restore full table.

* Edit.

* Backgrounding and DisplayDensityChanged event explanations.

* Edit.

* Tooltip support for views (#961)

* Tooltips.

* Limit to .NET 7 moniker.

* Edit.

* Clarify tooltip use on iOS.

* Pointer gesture recognizer (#962)

* Add more info to troubleshooting area (#921)

* update troubleshooting

* minor

* Fix local file playback on iOS/Mac Catalyst. (#923)

* Update troubleshooting.md (#925)

* Add Azure mobile apps MAUI quickstart link (#954)

* Typo fix - update to create a custom control using handlers article (#957)

- Fix case of (ReplaceCurrentItemWIthPlayerItem).
- Change (These requirements imply that that video...) to (These requirements imply that video...).

* Add links to each step's code in the tutorial (#955)

* adjust code; add link to sample

* Update gitignore to include vscode

* Update AllNotes.cs

* Pointer gesture recognizer.

* Edit.

* Edits.

* Use moniker.

* Expand section on GetPosition

* Edit.

Co-authored-by: Andy (Steve) De George <67293991+adegeo@users.noreply.github.com>
Co-authored-by: Muhab Abdelreheem <mabdulrahim2@outlook.sa>

* Tap gesture recognizer secondary button mask (#963)

* Secondary button mask on Mac and Windows.

* Edits.

* Fix link.

* Fix bookmark.

* Edit.

* Fix linting error.

* Menu item separators (#968)

* Menu separators.

* Fix monikers.

* Edit image.

* Context menu (#971)

* Context menus.

* Add section on displaying menu item icons.

* Edits.

* Fix linting errors.

* Add Windows warning. (#982)

* Window position and size (#984)

* Position and size a window.

* Remove OnDisplayDensityChanged

* Edit.

* Remove hard tabs.

* Specify WKWebViewConfiguration object on MauiMKWebView constructor (#988)

* MauiWKWebView configuration on iOS/Mac Catalyst.

* Edit.

* Edits.

* Move section.

* [NET 7] Remove the note about clean and redeploy to fix icons  (#983)

* remove workaround no longer needed

* swap delete to moniker

* .NET 7 doesn't require a subclassed AndroidMessageHandler (#1024)

* PointerOver visual state (#1027)

* Add PointerOver visual state.

* Fix typo.

* .NET 7 essentials updates (#1033)

* Unpackaged apps store data in a different location.

* Coarse or fine location can be specified on Android in .NET 7.

* Edit.

* Update date.

* No capabilities required on Window in .NET 7.

* Edit.

* Extend docs to include net7-based TFMs (#1049)

* Add .NET 7 support.

* Edit.

* Fix numbering.

* Add .NET 7 support.

* Edit.

* Edits.

* Fixes.

* Edit.

* Edit.

* Add .NET 7 support.

* Add .NET 7 support.

* More .NET 7.

* More .NET 7

* Fix typo.

* Remove moniker because you still need to clean the project.

* Fix linting error.

* .NET 7 updates (#1053)

* Update installation for .NET 7.

* Fix broken link.

* VSMac update.

* Test .NET 6/7 selector.

* Test

* Test

* Edits.

* Edits.

* New installations will have iOS/Android auto-selected.

* Update screenshots.

* Remove space in monikers.

* Fix sample link.

* Foldable devices with .NET MAUI (#1057)

* [foldable] TwoPaneView doc

* [foldable] address markdownlint warnings

* [foldable] address markdownlint warning

* [foldable] update sample link

* Update docs/user-interface/controls/twopaneview.md

Co-authored-by: David Britch <davidbritch@users.noreply.github.com>

* Update docs/user-interface/controls/twopaneview.md

Co-authored-by: David Britch <davidbritch@users.noreply.github.com>

* Update docs/user-interface/controls/twopaneview.md

Co-authored-by: David Britch <davidbritch@users.noreply.github.com>

* Update docs/user-interface/controls/twopaneview.md

Co-authored-by: David Britch <davidbritch@users.noreply.github.com>

* Update docs/user-interface/controls/twopaneview.md

Co-authored-by: David Britch <davidbritch@users.noreply.github.com>

* Update docs/user-interface/controls/twopaneview.md

Co-authored-by: David Britch <davidbritch@users.noreply.github.com>

* Update docs/user-interface/controls/twopaneview.md

Co-authored-by: David Britch <davidbritch@users.noreply.github.com>

* Update docs/user-interface/controls/twopaneview.md

Co-authored-by: David Britch <davidbritch@users.noreply.github.com>

* [foldable] impl review feedback

* Update docs/user-interface/controls/twopaneview.md

Co-authored-by: David Britch <davidbritch@users.noreply.github.com>

* Update docs/user-interface/controls/twopaneview.md

Co-authored-by: David Britch <davidbritch@users.noreply.github.com>

* Update docs/user-interface/controls/twopaneview.md

Co-authored-by: David Britch <davidbritch@users.noreply.github.com>

Co-authored-by: David Britch <davidbritch@users.noreply.github.com>

* Deprecate MessagingCenter.

* Move note.

Co-authored-by: Andy (Steve) De George <67293991+adegeo@users.noreply.github.com>
Co-authored-by: Muhab Abdelreheem <mabdulrahim2@outlook.sa>
Co-authored-by: Craig Dunn <craig.dunn@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidbritch davidbritch davidbritch approved these changes

Assignees
No one assigned
Labels
🏁 Release: .NET 9 Work items for the .NET 9 release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@conceptdev @davidbritch