Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Splash screen #125

Closed
wants to merge 13 commits into from
Closed

Splash screen #125

wants to merge 13 commits into from

Conversation

davidbritch
Copy link
Contributor

Fixes #19

adegeo
adegeo approved these changes Aug 19, 2021
View reviewed changes
Copy link
Contributor

@adegeo adegeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Some minor suggestions to consider.

docs/user-interface/splashscreen.md Outdated Show resolved Hide resolved
docs/user-interface/splashscreen.md Outdated Show resolved Hide resolved
docs/user-interface/splashscreen.md Outdated Show resolved Hide resolved
docs/user-interface/splashscreen.md Outdated Show resolved Hide resolved
davidbritch and others added 2 commits August 20, 2021 09:24
@davidbritch @adegeo
Update docs/user-interface/splashscreen.md
32b7260 
Co-authored-by: Andy (Steve) De George <67293991+adegeo@users.noreply.github.com>
@davidbritch
Feedback incorporated.
cf194da
@MartyIX
Copy link
Contributor

MartyIX commented Oct 17, 2021

Could you please add a note about Windows and splash screens?

jonathanpeppers
jonathanpeppers reviewed Dec 7, 2021
View reviewed changes
Copy link
Member

@jonathanpeppers jonathanpeppers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only other thing I was thinking of is maybe some side-by-side screenshots of the app launching? You might be able to put a Thread.Sleep(3000) in an app to make it easier to get the screenshot.

docs/user-interface/images/splashscreens.md Outdated Show resolved Hide resolved
docs/user-interface/images/splashscreens.md Outdated Show resolved Hide resolved
docs/user-interface/images/splashscreens.md Outdated Show resolved Hide resolved
@davidbritch davidbritch mentioned this pull request Dec 8, 2021
Merged
@davidbritch
Copy link
Contributor Author

Replaced with #232 , which merges into the release branch.

@davidbritch davidbritch closed this Dec 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonathanpeppers jonathanpeppers jonathanpeppers left review comments

@adegeo adegeo adegeo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Splash screens
4 participants
@davidbritch @MartyIX @jonathanpeppers @adegeo