Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Foldable devices with .NET MAUI #956

Closed
wants to merge 43 commits into from
Closed

Conversation

conceptdev
Copy link
Contributor

@conceptdev conceptdev commented Sep 30, 2022

Initial proposal for the Foldable NuGet docs.

  • What is the right location in the TOC? Currently in Fundamentals but could belong in User Interface > Views ?
  • Whether to include DualScreenInfo?
  • Whether to include Triggers?
  • More samples required?

@conceptdev conceptdev added 🏁 Release: .NET 9 Work items for the .NET 9 release do-not-merge labels Sep 30, 2022
@conceptdev conceptdev changed the base branch from main to net7 September 30, 2022 23:01
mahab339 and others added 2 commits October 12, 2022 11:10
Change (`Center`, of type `PointF`. which specifies...) to (...of type `PointF`, which...).
Copy link
Contributor

@davidbritch davidbritch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe add your alias/github to the metadata, so you get to see any issues opened by users.

docs/fundamentals/foldable/twopaneview.md Outdated Show resolved Hide resolved
docs/fundamentals/foldable/twopaneview.md Outdated Show resolved Hide resolved
conceptdev and others added 20 commits October 14, 2022 14:14
…997)

* initial articles for android/windows

* add android files

* various errors

* minor fixes

* Apply suggestions from code review

Co-authored-by: David Britch <davidbritch@users.noreply.github.com>

* fix svg

* Update docs/android/deployment/overview.md

Co-authored-by: David Britch <davidbritch@users.noreply.github.com>

Co-authored-by: David Britch <davidbritch@users.noreply.github.com>
- Change `SweepDirection` enumeration members description to reflect corresponding values.
- Change  (... type `GeometryCollection`, which species the objects that define...) to (.. type `GeometryCollection`, which specifies...).
Change (.... also have a `StrokeDashOffset` property ,...) to (... have a `StrokeDashOffset` property, ...).
- Change (`-Infinity` represents `double.NegativeInfinity`.) to (`-Infinity` represents...). 
- Change (... two specified control point.) to (...  two specified control points.)
Change (CacheValidity="10:00:00.0") to (CacheValidity="10:00:00"). 
Reason: extra zero produces error:  "The TimeSpan could not be parsed because at least one of the numeric components is out of range or contains too many digits.". 
Project workload: .NET Maui 7.0.0.
* Update troubleshooting.md

* Update troubleshooting.md
* Update image.md

Fix XAML example of a 10-day TimeSpan.

* Update image.md

Co-authored-by: David Britch <davidbritch@users.noreply.github.com>
mahab339 and others added 17 commits October 28, 2022 15:29
Change (...enter and edit multiple lines of text.]) to (...multiple lines of text.).
Added some missing double quotes in the ContentPage tag.
* Add necessary overrides in MainActivity

* Edit text to correctly reference code snippet.

* Edit.

Co-authored-by: David Britch <davidbritch@users.noreply.github.com>
@conceptdev conceptdev mentioned this pull request Nov 3, 2022
4 tasks
@conceptdev
Copy link
Contributor Author

Screwed up the branch, moved to #1057

@conceptdev conceptdev closed this Nov 3, 2022
@conceptdev conceptdev deleted the conceptdev-605-foldable branch November 3, 2022 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏁 Release: .NET 9 Work items for the .NET 9 release do-not-merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants