Rules for Memory appear to be wrong

[bencyoung]

Rule #3 and #4 appear to be wrong where they place

string defensiveCopy = message.ToString();

I think these should be called before the task is run (outside the delegate), else the copy can still be corrupted by the time it is made...

---

Document Details

⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

• ID: 4819512e-1044-1c57-0de1-447164220fd5
• Version Independent ID: d6cf8d26-fb2f-7138-f0c7-ab529a5b9cde
• Content: Memory<T> and Span<T> usage guidelines
• Content Source: docs/standard/memory-and-spans/memory-t-usage-guidelines.md
• Product: dotnet
• GitHub Login: @rpetrusha
• Microsoft Alias: ronpet

[kylejrp]

Discussion on Reddit: https://www.reddit.com/r/csharp/comments/b4np6w/memoryt_and_spant_usage_guidelines/ej85l5a?utm_source=share&utm_medium=web2x

[rpetrusha]

Thanks for your feedback, @bencyoung, and for the link to the discussion on Reddit, @kylejrp. I'll address these issues in our May sprint.

[rpetrusha]

This has been partially addressed in dotnet/samples#842.