Make new 7 interactive #11442
Merged
Make new 7 interactive #11442
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rpetrusha
suggested changes
Mar 21, 2019
There was a problem hiding this comment.
I've left a number of suggestions and comments, @BillWagner. I've requested changes rather than approved, since I'd like to review this again once it becomes more interactive.
BillWagner
force-pushed
the
make-new-7-interactive
branch
from
57c1b06 to
3b09b46
Compare
BillWagner
added a commit
to BillWagner/samples
that referenced
this pull request
Mar 27, 2019
Many of the samples changed. This sample now supports "What's new in C# 7", and the exploratory tutorial for C# 7. Required for dotnet/docs#11442
A very thorough early review from Ron Co-Authored-By: BillWagner <wiwagn@microsoft.com>
BillWagner
force-pushed
the
make-new-7-interactive
branch
from
14ce792 to
699ad23
Compare
pkulikov
reviewed
Mar 27, 2019
Co-Authored-By: BillWagner <wiwagn@microsoft.com>
BillWagner
added a commit
to dotnet/samples
that referenced
this pull request
Mar 28, 2019
Many of the samples changed. This sample now supports "What's new in C# 7", and the exploratory tutorial for C# 7. Required for dotnet/docs#11442
|
closing and opening for a new build |
|
@rpetrusha I just updated the build, and gave it a quick look. It's ready for a fresh review. |
|
One of pattern matching samples behaves incorrectly in the try.net experience See dotnet/try#175 |
These don't work unless the sample in the browser is a full program. Ref returns in snippets don't compile in the current scaffolding.
rpetrusha
approved these changes
Mar 29, 2019
There was a problem hiding this comment.
This looks good, @BillWagner. Once the REPL is working, we should remember to revisit the interactive examples to make sure that they work. I've left a number of comments and suggestions, but feel free to merge when you want and, if necessary, address them later.
Co-Authored-By: BillWagner <wiwagn@microsoft.com>
Co-Authored-By: BillWagner <wiwagn@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5432
Fixes #7506
Contributes to #8206
Internal review links:
What's new in C# 7
Explore C# 7