Update SentimentAnalysis tutorial to 1.0-preview #11816
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JRAlexander
changed the title
natke
requested changes
Apr 16, 2019
Contributor
natke
left a comment
natke
left a comment
There was a problem hiding this comment.
Some general comments:
- the Build and Train Model section doesn't actually build and train the model - it more sets up skeleton functions
- In the closing para, you mentioned hyper-parameters but we've not defined these yet
- There is some confusion between the machine learning task and the algorithm to choose for that task. (And I know we don't provide good guidance on that rn). It would be good to clarify this, even if we remain a little vague about why we chose the Scda algorithm.
- I'm not sure we need to save and re-load the model in every single tutorial. This seems like an operational feature that developers could learn about from our How-to on the topic.
| "Is it A or B?" | ||
|
|
||
| Add the following code to the `BuildAndTrainModel` method: | ||
|  |
Contributor
There was a problem hiding this comment.
Should we put in an art request to get this artified?
Contributor
Author
There was a problem hiding this comment.
Sure. Can we leave it for now in the meantime and replace later?
| [!code-csharp[TrainModel](~/samples/machine-learning/tutorials/SentimentAnalysis/Program.cs#TrainModel "Train the model")] | ||
|
|
||
| ### Save and Return the model trained to use for evaluation | ||
| The [Fit()](xref:Microsoft.ML.Trainers.MatrixFactorizationTrainer.Fit%28Microsoft.ML.IDataView,Microsoft.ML.IDataView%29) method trains your model with the provided training dataset. It executes the `Estimator` definitions by transforming the data and applying the training, and it returns back the trained model, which is a `Transformer`. |
Contributor
There was a problem hiding this comment.
Suggest: The Fit() method uses the training data to calculate the parameters of the model.
Contributor
Author
There was a problem hiding this comment.
Not sure that is clearer. Made an edit. What do you think?
…r/docs into jralexander-041119-01 Resyncing
luisquintanilla
requested changes
Apr 17, 2019
Contributor
luisquintanilla
left a comment
luisquintanilla
left a comment
There was a problem hiding this comment.
Look good. Minor changes.
| |Wow... Loved this place. | 1 | | ||
| |Service was very prompt. | 1 | | ||
|
|
||
| `SentimentPrediction` is the prediction class used after the model training. It has a single boolean (`Sentiment`) and a `PredictedLabel` `ColumnName` attribute. The `Label` is used to create and train the model, and it's also used with the split out test dataset to evaluate the model. The `PredictedLabel` is used during prediction and evaluation. For evaluation, training data, the predicted values, and the model are used. |
Contributor
There was a problem hiding this comment.
Suggestion: Add xref to ColumnName.
Contributor
Author
There was a problem hiding this comment.
Its xreffed in the previous paragraph.
| Add the following code to the `BuildAndTrainModel` method: | ||
| ## Train the model | ||
|
|
||
| Fit the model to the `Train` data and return the trained model by adding the following as the next line of code in the `BuildAndTrainModel()` method: |
Contributor
There was a problem hiding this comment.
Not sure if Train needs to be inlined.
luisquintanilla
approved these changes
Apr 17, 2019
natke
approved these changes
Apr 18, 2019
Contributor
natke
left a comment
natke
left a comment
There was a problem hiding this comment.
One minor comment. Other than that LGTM!
|
|
||
| [!code-csharp[Predict](~/samples/machine-learning/tutorials/SentimentAnalysis/Program.cs#Predict "Create a prediction of sentiment")] | ||
|
|
||
| The [Predict()](xref:Microsoft.ML.PredictionEngine%602.Predict%2A) function makes a prediction on a single column of data. |
Contributor
Author
|
Thanks, @luisquintanilla and @natke!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Internal Review URL
Fixes #11859
Fixes #11779
Code here: dotnet/samples#81