Formatting on console-teleprompter #1210
Conversation
Update console-teleprompter.md Update console-teleprompter.md Update console-teleprompter.md
|
Open Publishing Build Service: The pull request content has been published and here are some changed files links of this time:
Status: Succeeded. |
There was a problem hiding this comment.
- I think
Programshould be formatted as code - "It's" should be lowercase, since it is part of the sentence now
|
@svick I made the suggested updates. |
✅ Validation status: passed
For more details, please refer to the build report. Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report. |
There was a problem hiding this comment.
It might be better to change File to @System.IO.File so that it's resolved as a link.
There was a problem hiding this comment.
Here again, it might be better to change these from IDisposable to @System.IDisposable, and from Dispose to @System.IDisposable.Dispose so that they resolve as links.
There was a problem hiding this comment.
Here again, FIle.OpenText could be File.OpenText so it resolves as a link. Similarly, @System.IO.StreamReader instead of StreamReader.
There was a problem hiding this comment.
Task-returning. Task could be a link -- @System.Threading.Tasks.Task.
There was a problem hiding this comment.
Maybe resolve this as a link -- @System.Threading.Tasks.Task.Wait.
@BillWagner
There was a problem hiding this comment.
Here the link would be helpful -- @System.Action. Also, perhaps "Action delegate"?
There was a problem hiding this comment.
Replace with a link to @System.Console.ReadKey?
There was a problem hiding this comment.
Replace with a link to Task.WhenAny?
|
Responded to @rpetrusha feedback and re-squashed. |
|
@rpetrusha I made all your suggested changes. Do you want to review again, or is it ready to ship? |
✅ Validation status: passed
For more details, please refer to the build report. Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report. |
|
@BillWagner I'll review it again quickly. |
There was a problem hiding this comment.
typo: @System.IDisposable
There was a problem hiding this comment.
should be @System.IO.File.OpenText
There was a problem hiding this comment.
typo: @System.IO.StreamReader
There was a problem hiding this comment.
This doesn't resolve. Should be @System.Threading.Tasks.Task.WhenAny(System.Threading.Tasks.Task[]).
|
@BillWagner A few links didn't resolve. For the last one, you could also use |
Also, updated the freshness date, and add the ms.author metadata tag. Respond to updated feedback Respond to @rpetrusha feedback. Fix a few broken links
✅ Validation status: passed
For more details, please refer to the build report. Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report. |
|
rebasing and merging. Thanks @rpetrusha |
6 participants
This addresses the final feedback in PR #1073. I’ll close that PR as this replaces it.
Important: Please to a merge commit instead of a squash commit when we merge this. We want to preserve the original PR commits, including the committer