Update samples for try.net scaffolding #12508
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This tutorial is one of the tutorials that needs to be whitelisted to use the scriptcs implementation. These changes update the code so that the sample works with the standard scaffolding implemented by docs.microsoft.com
rchande
approved these changes
May 23, 2019
rpetrusha
approved these changes
May 23, 2019
Contributor
rpetrusha
left a comment
rpetrusha
left a comment
There was a problem hiding this comment.
LGTM, @BillWagner. I left three comments, the first two of which you can feel free to ignore. The third is about the absence of the C2 standard numeric format string. You can merge when you're ready.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This tutorial is one of the tutorials that needs to be whitelisted to use the scriptcs implementation.
These changes update the code so that the sample works with the standard scaffolding implemented by docs.microsoft.com
/cc @rchande