Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make readable #1325

Merged
merged 3 commits into from
Dec 14, 2016
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 8 additions & 7 deletions docs/core/tutorials/target-dotnetcore-with-msbuild.md
Original file line number Diff line number Diff line change
Expand Up @@ -17,15 +17,16 @@ The .NET Core tooling is going to [move from project.json to MSBuild based proje
We expect the first version of the .NET Core tools that use MSBuild to ship along with the next version of Visual Studio. However, it is possible to use MSBuild for .NET Core
projects today, and this page shows how.

We recommend that most people targeting .NET Core with *new* projects today use the default tooling experience with project.json because of the following
reasons:
We recommend new projects targeting .NET Core use the default tooling with *project.json* for the following reasons:

- MSBuild doesn't yet support a lot of the benefits of project.json
- A lot of the ASP.NET based tooling doesn't currently work with MSBuild projects
- When we do release the .NET Core tooling that uses MSBuild, it will be able to automatically convert from project.json to MSBuild projects
- MSBuild doesn't yet support many of the benefits of *project.json*.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"features" might be a better term -- "benefits" seems to me to be very marketing-focused.

- Much of the ASP.NET based tooling doesn't currently work with MSBuild projects.
- When MSBuild based .NET Core tooling is released, it convert *project.json* to MSBuild based.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

...it will automatically convert project.json to an MSBuild-based project file.


You may want to use MSBuild to target .NET Core for existing projects that already use MSBuild that you want to port to .NET Core, or if you are using
MSBuild's extensibility in your build for scenarios that are not well supported for project.json projects.
When to consider using MSBuild:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider using MSBuild when:


- .NET Core projects using MSBuild that are being ported to .NET Core.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Existing projects that use MSBuild are being ported...

- Projects that use MSBuild's extensibility that are not well suported for *project.json*.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Projects use MSBuild's extensibility features that...
well-supported by


## Prerequisites

Expand Down