-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move C# compiler pages to single dir #16449
Conversation
@@ -956,6 +956,10 @@ | |||
"source_path": "docs/csharp/methods-lambda-expressions.md", | |||
"redirect_url": "/dotnet/csharp/programming-guide/statements-expressions-operators/lambda-expressions" | |||
}, | |||
{ | |||
"source_path": "docs/csharp/misc/", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this works currently. @Sampy can you verify?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've sent a couple emails to verify. Folks are still out on holiday. It will be next week before I get clear answers.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Bill! If not, I can hack something together to create entries for each file. 😊
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a workaround we can do that would avoid adding the entry for each file but is not as transparent. If there's no file rename might be easier.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@BillWagner is this PR on hold until folder-level redirects are implemented?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes @tdykstra That's correct. I'd like to keep it open (even while I know it's amassing more merge conflicts).
I'm using this as an example of one scenario we need to support.
Hey @BillWagner - any news on the directory redirection feature? 🙂 It's been a while - do you think we should write the files out explicitly? Or if not, perhaps just close this PR until things are ready. Let me know what you thinks best - thanks! |
@ChrisMaddock I wish I had better news. The folder level redirection is still in the backlog. I think it's stale enough that closing it makes sense. At least for now. I'm hoping we can have a better plan between now and .NET 5.0. I'm working on some options. |
No worries - thanks @BillWagner. 👍 |
Contributes to #1491 and #2363
I haven't yet touched the TOC, this is big enough for one PR. Note these pages weren't listed in any TOC in their previous location either - and the next part of #2363 is to get rid of the TOC entirely.
I hope the folder redirect works - let me know if it needs changing. 😊