Add note about omitted fractional-second digits when formatting DT(Offset)s in System.Text.Json #16863
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… in System.Text.Json
layomia
force-pushed
the
fraction_zeros
branch
from
abd4401 to
7c0a577
Compare
Contributor
Author
tdykstra
changed the title
tdykstra
approved these changes
Jan 28, 2020
Contributor
tdykstra
left a comment
tdykstra
left a comment
There was a problem hiding this comment.
Looks good, just a typo fix and minor wording suggestions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adding this information in response to dotnet/runtime#556, where a community member wanted to know if trailing zeros should, in fact, be written.
Fixes #16128.