Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document AssetTargetFallback #17392

Merged
merged 3 commits into from
Mar 10, 2020
Merged

Document AssetTargetFallback #17392

merged 3 commits into from
Mar 10, 2020

Conversation

gewarren
Copy link
Contributor

@gewarren gewarren commented Mar 9, 2020

Fixes #2816

Copy link
Member

@rainersigwald rainersigwald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but @nkolev92's signoff counts 10x mine on this.

Copy link
Contributor

@nkolev92 nkolev92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great.

The docs for this are overdue.

On NuGet side we are planning on adding some examples, maybe we can link those when we get to that ourselves.

<Project Sdk="Microsoft.NET.Sdk">
...
<PropertyGroup>
<AssetTargetFallback>netstandard1.6</AssetTargetFallback>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd use a closer to real world example, a net*** framework like net461, looks great beyond that.

We have an issue on NuGet side to document this as well, but unfortunately we haven't merged it, https://github.com/NuGet/docs.microsoft.com-nuget/issues/511.

Co-Authored-By: Nikolche Kolev <nikolev@microsoft.com>
@gewarren
Copy link
Contributor Author

Thanks for the reviews Rainer and Nikolche.

@gewarren gewarren merged commit 805fdeb into dotnet:master Mar 10, 2020
@gewarren gewarren deleted the 2816 branch March 10, 2020 06:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[2.0] Describe AssetTargetFallback
5 participants