-
Notifications
You must be signed in to change notification settings - Fork 6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document AssetTargetFallback #17392
Document AssetTargetFallback #17392
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but @nkolev92's signoff counts 10x mine on this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great.
The docs for this are overdue.
On NuGet side we are planning on adding some examples, maybe we can link those when we get to that ourselves.
<Project Sdk="Microsoft.NET.Sdk"> | ||
... | ||
<PropertyGroup> | ||
<AssetTargetFallback>netstandard1.6</AssetTargetFallback> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd use a closer to real world example, a net***
framework like net461
, looks great beyond that.
We have an issue on NuGet side to document this as well, but unfortunately we haven't merged it, https://github.com/NuGet/docs.microsoft.com-nuget/issues/511.
Co-Authored-By: Nikolche Kolev <nikolev@microsoft.com>
Thanks for the reviews Rainer and Nikolche. |
Fixes #2816