Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

General updates. #17951, #17020, and #9884 #18151

Merged
merged 1 commit into from
Apr 29, 2020

Conversation

IEvangelist
Copy link
Member

@IEvangelist IEvangelist commented Apr 29, 2020

Summary

Finally, after searching through all of the existing samples, tutorials, and docs I have been unable to find any incorrect references to metapackage usage, or legacy netcoreapp1.x usages. I believe that this also verifies #2726. All of the files where the term "metapackage" is used are accurate.

  • .\docs\core\packages.md
  • .\docs\core\toc.yml
  • .\docs\core\deploying\index.md
  • .\docs\core\porting\libraries.md
  • .\docs\core\project-sdk\msbuild-props.md
  • .\docs\core\tools\csproj.md
  • .\docs\standard\frameworks.md
  • .\docs\standard\glossary.md
  • .\docs\standard\assembly\reference-assemblies.md

Fixes #2726, closes #9884, resolves #17020, fixes #17951

@IEvangelist IEvangelist requested a review from gewarren April 29, 2020 13:33
@IEvangelist IEvangelist requested a review from a team as a code owner April 29, 2020 13:33
@IEvangelist IEvangelist self-assigned this Apr 29, 2020
@dotnet-bot dotnet-bot added this to the May 2020 milestone Apr 29, 2020
Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM @IEvangelist

You can :shipit: when ready.

@IEvangelist IEvangelist merged commit 18497d7 into dotnet:master Apr 29, 2020
@IEvangelist IEvangelist deleted the metapackages branch April 29, 2020 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants