-
Notifications
You must be signed in to change notification settings - Fork 6.1k
Add Stack<T> converter example #18358
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@layomia do we have an issue to round-trip stack "properly" for 5.0? |
BillWagner
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This LGTM @tdykstra. You can
when ready.
When would you want to move these snippets into the new location?
I think the diff would be too confusing to do it in the same PR as an update to the code, so I'll do it separately, will try to get to it this week. |
@steveharter |
ahsonkhan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Otherwise, looks good.
docs/standard/serialization/system-text-json-converters-how-to.md
Outdated
Show resolved
Hide resolved
samples/snippets/core/system-text-json/csharp/RoundtripStackOfT.cs
Outdated
Show resolved
Hide resolved
samples/snippets/core/system-text-json/csharp/RoundtripStackOfT.cs
Outdated
Show resolved
Hide resolved
samples/snippets/core/system-text-json/csharp/RoundtripStackOfT.cs
Outdated
Show resolved
Hide resolved
samples/snippets/core/system-text-json/csharp/RoundtripStackOfT.cs
Outdated
Show resolved
Hide resolved
docs/standard/serialization/system-text-json-converters-how-to.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Ahson Khan <ahkha@microsoft.com>
…T.cs Co-authored-by: Ahson Khan <ahkha@microsoft.com>
…T.cs Co-authored-by: Ahson Khan <ahkha@microsoft.com>
…T.cs Co-authored-by: Ahson Khan <ahkha@microsoft.com>
…T.cs Co-authored-by: Ahson Khan <ahkha@microsoft.com>
Fixes #16690
cc @ahsonkhan