Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add F1 keywords for combination keywords #19700

Merged
merged 1 commit into from
Jul 27, 2020

Conversation

davidwengier
Copy link
Contributor

Summary

In preparation of fixing dotnet/roslyn#46142 we need to add keywords to the combination modifier pages.

Is there anything else I need to do for this to work, or will indexing pick up these automatically?

@davidwengier
Copy link
Contributor Author

Opened dotnet/roslyn#46343 which will use these new keywords. I'll hold off merging that until this is merged, and published.

Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @davidwengier

This is all that's needed.

I'll :shipit: now.

@BillWagner BillWagner merged commit d87bfaf into dotnet:master Jul 27, 2020
@davidwengier davidwengier deleted the CombinationKeywordHelp branch July 27, 2020 21:45
@davidwengier
Copy link
Contributor Author

Thanks @BillWagner. Is there any way to track when this goes live, or rather when the search index might be updated?

Otherwise I'll just keep hitting this URL until it works:
https://msdn.microsoft.com/query/dev16.query?appId=Dev16IDEF1&l=EN-US&k=k(privateprotected_CSharpKeyword);k(DevLang-csharp)&rd=true

@davidwengier
Copy link
Contributor Author

Looks like my link works! :)

@BillWagner
Copy link
Member

@davidwengier We publish once a day, so it should be live now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants