Skip to content

Fix dotnet-sdk-2.1 version recommendation: SDK #19921

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 10, 2020
Merged

Fix dotnet-sdk-2.1 version recommendation: SDK #19921

merged 1 commit into from
Aug 10, 2020

Conversation

dagood
Copy link
Member

@dagood dagood commented Aug 9, 2020

I think this is wrong and the SDK package should use <sdk version>:

  • dotnet-sdk-[major].[minor] - Installs the latest sdk for specific runtime
    • Version: <runtime version>

It looks like this started with a mistake in my suggestion at #13196 (comment), so I doubt there was any reason for it to be <runtime version>.

/cc @tmds @omajid

@dagood dagood requested a review from a team as a code owner August 9, 2020 01:55
@dagood dagood self-assigned this Aug 9, 2020
@dotnet-bot dotnet-bot added this to the August 2020 milestone Aug 9, 2020
@dagood dagood mentioned this pull request Aug 9, 2020
Closed
omajid
omajid approved these changes Aug 10, 2020
View reviewed changes
Copy link
Member

@omajid omajid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching and fixing this!

tdykstra
tdykstra approved these changes Aug 10, 2020
View reviewed changes
Copy link
Contributor

@tdykstra tdykstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@tdykstra tdykstra merged commit 8d01b39 into dotnet:master Aug 10, 2020
@dagood dagood deleted the sdk-version branch August 10, 2020 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@omajid omajid omajid approved these changes

@tdykstra tdykstra tdykstra approved these changes

Assignees

@dagood dagood

Labels
None yet
Projects
None yet
Milestone
August 2020
Development

Successfully merging this pull request may close these issues.
5 participants
@dagood @omajid @tdykstra @BillWagner @dotnet-bot