Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add description of debugging test unit #20494

Merged
merged 5 commits into from
Sep 23, 2020
Merged

Add description of debugging test unit #20494

merged 5 commits into from
Sep 23, 2020

Conversation

johypark
Copy link
Contributor

@johypark johypark commented Sep 8, 2020

Summary

Fix minor example of output
Add description of debugging test unit

@johypark
Copy link
Contributor Author

johypark commented Sep 8, 2020

When should I update ms.date?

@IEvangelist
Copy link
Member

I do not believe that we should make these changes. The example output is just that, and with these changes horizontal scrolling is introduced. We try to avoid that where possible.

Thank you for taking the time to propose these changes, but I'd prefer to keep it as is. I'm going to close this for now, let me know if you want to discuss it further.

@IEvangelist IEvangelist closed this Sep 8, 2020
@johypark
Copy link
Contributor Author

johypark commented Sep 8, 2020

@IEvangelist Thank you for check my request.
I agree with your comment, but I don't understand that horizontal scrolling is introduced because the line 147 that the new one is shorter than line 148 that the original one.
And when should I update ms.date? I check some reference of contributing guide, but I can't find it.
Could you tell me about these questions? Thank you.

@IEvangelist
Copy link
Member

Hi @johypark,

The ms.date should be updated when/if an article is significantly updated and validated for accuracy. Minor tweaks do not typically warrant updating this metadata. Does that make sense?

Also, I apologize about the misunderstanding. When I initially looked at this, it appeared as though you were removing the new line and making it one larger line which would have introduced scrolling.

@IEvangelist IEvangelist reopened this Sep 8, 2020
@johypark johypark changed the title Fix minor output Add description of debugging test unit Sep 8, 2020
@johypark
Copy link
Contributor Author

johypark commented Sep 8, 2020

@IEvangelist Thank you for your answer which I clearly understand.

Copy link
Member

@IEvangelist IEvangelist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nits.

Co-authored-by: David Pine <david.pine@microsoft.com>
@johypark johypark requested a review from IEvangelist September 9, 2020 17:01
Copy link
Member

@IEvangelist IEvangelist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, we'll :shipit: - thank you 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants