Supported collection types doc for System.Text.Json #22217
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gewarren
reviewed
Jan 5, 2021
docs/standard/serialization/system-text-json-supported-collection-types.md
Show resolved
Hide resolved
docs/standard/serialization/system-text-json-supported-collection-types.md
Show resolved
Hide resolved
docs/standard/serialization/system-text-json-supported-collection-types.md
Show resolved
Hide resolved
docs/standard/serialization/system-text-json-supported-collection-types.md
Outdated
Show resolved
Hide resolved
docs/standard/serialization/system-text-json-supported-collection-types.md
Outdated
Show resolved
Hide resolved
docs/standard/serialization/system-text-json-supported-collection-types.md
Outdated
Show resolved
Hide resolved
gewarren
reviewed
Jan 5, 2021
docs/standard/serialization/system-text-json-supported-collection-types.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com>
gewarren
approved these changes
Jan 5, 2021
Contributor
gewarren
left a comment
gewarren
left a comment
There was a problem hiding this comment.
Left a couple final suggestions.
docs/standard/serialization/system-text-json-supported-collection-types.md
Show resolved
Hide resolved
docs/standard/serialization/system-text-json-supported-collection-types.md
Outdated
Show resolved
Hide resolved
docs/standard/serialization/system-text-json-supported-collection-types.md
Outdated
Show resolved
Hide resolved
tdykstra
commented
Jan 5, 2021
docs/standard/serialization/system-text-json-supported-collection-types.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com>
Contributor
Author
|
Thanks for the review @gewarren! |
gewarren
reviewed
Jan 5, 2021
|
|
||
| ::: zone-end | ||
|
|
||
| \* See [Support round trip for Stack\<T>](system-text-json-converters-how-to.md#support-round-trip-for-stackt). |
Contributor
There was a problem hiding this comment.
It didn't indent properly, I guess because it's separated from the zone. You might add is separately to each zone so it 1) is indented and 2) appears before the double asterisk.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #15807
Internal review URL