Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update for version selection articles #25039

Merged
merged 5 commits into from
Jul 9, 2021
Merged

Update for version selection articles #25039

merged 5 commits into from
Jul 9, 2021

Conversation

adegeo
Copy link
Contributor

@adegeo adegeo commented Jul 8, 2021

Summary

  • Added MSBuild props for RollFoward and RuntimeFrameworkVersion (internal preview) @gewarren
  • Expanded Select which .NET version to use with more information about roll forward. Also updated examples to be .NET 5 focused instead of .NET Core 3.1 (internal preview)
  • Clarified How .NET Runtime and SDK are versioned (internal preview)

Fixes #12237

@vitek-karas @agocke

@adegeo adegeo requested review from agocke, vitek-karas and gewarren July 8, 2021 17:10
@adegeo adegeo requested a review from a team as a code owner July 8, 2021 17:10
@dotnet-bot dotnet-bot added this to the July 2021 milestone Jul 8, 2021
@adegeo adegeo removed the request for review from a team July 8, 2021 17:10

### Precedence

Roll forward behavior is considered in the following order:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is confusing (at least to me). Reading this I would assume the runtimeconfig.json is the higher priority and thus overrides all of the other options, but it's actually the other way round. I think there should be an explanation of what the order in this list means.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, I added some descriptions on each of the items.

@vitek-karas
Copy link
Member

Thanks a lot for making these changes!

adegeo and others added 3 commits July 8, 2021 12:01
Co-authored-by: Vitek Karas <vitek.karas@microsoft.com>
Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com>
Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com>
@adegeo adegeo requested review from vitek-karas and gewarren July 8, 2021 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Major-version roll-forward options for Core 3.0
4 participants