Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

C# project templates breaking change #25411

Merged
merged 5 commits into from
Aug 3, 2021
Merged

C# project templates breaking change #25411

merged 5 commits into from
Aug 3, 2021

Conversation

gewarren
Copy link
Contributor

@gewarren gewarren commented Jul 31, 2021 •
edited
Loading

@dotnet-bot dotnet-bot added this to the July 2021 milestone Jul 31, 2021
@gewarren gewarren requested review from vlada-shubina and a team July 31, 2021 01:36
tdykstra
tdykstra approved these changes Aug 2, 2021
View reviewed changes
Copy link
Contributor

@tdykstra tdykstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

docs/core/compatibility/sdk/6.0/csharp-template-code.md Outdated Show resolved Hide resolved
docs/core/compatibility/sdk/6.0/csharp-template-code.md Outdated Show resolved Hide resolved
@gewarren @tdykstra
Apply suggestions from code review
58629dc 
Co-authored-by: Tom Dykstra <tdykstra@microsoft.com>
@gewarren gewarren merged commit 3e77268 into dotnet:main Aug 3, 2021
@gewarren gewarren deleted the csharp-templates branch August 3, 2021 22:39
@gewarren
Copy link
Contributor Author

gewarren commented Aug 3, 2021

Thanks Tom!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tdykstra tdykstra tdykstra approved these changes

@vlada-shubina vlada-shubina Awaiting requested review from vlada-shubina

Assignees
No one assigned
Labels
dotnet-fundamentals/svc
Projects
None yet
Milestone
July 2021
Development

Successfully merging this pull request may close these issues.

[Breaking change]: C# code created using .NET 6 templates does not support targeting earlier .NET versions
3 participants
@gewarren @tdykstra @dotnet-bot