mac reqs - updates for 2.0 and link fixes #2569
Conversation
docs/core/macos-prerequisites.md
Outdated
| @@ -38,14 +38,16 @@ ln -s /usr/local/opt/openssl/lib/libcrypto.1.0.0.dylib /usr/local/lib/ | |||
| ln -s /usr/local/opt/openssl/lib/libssl.1.0.0.dylib /usr/local/lib/ | |||
| ``` | |||
|
|
|||
| Download and install the .NET Core SDK from [.NET Downloads](https://www.microsoft.com/net/download/core). If you have problems with the installation on macOS, consult the [Known issues & workarounds](https://github.com/dotnet/core/blob/master/cli/known-issues.md) topic. | |||
| Download and install the .NET Core SDK from [.NET Downloads](https://www.microsoft.com/net/download/core). If you have problems with the installation on macOS, consult the [1.0.0 Known Issues](https://github.com/dotnet/core/blob/master/release-notes/1.0/1.0.0-known-issues.md) and [1.0.1 Known Issues](https://github.com/dotnet/core/blob/master/release-notes/1.0/1.0.0-known-issues.md) topics. | |||
There was a problem hiding this comment.
This one for the 1.0.1 link?
https://github.com/dotnet/core/blob/master/release-notes/1.0/1.0.1-known-issues.md
There was a problem hiding this comment.
Yes, updated the link text but not the link when I copied. Good catch!
|
|
||
| **.NET Core 2.x** | ||
|
|
||
| Download and install the .NET Core SDK from [.NET Downloads](https://www.microsoft.com/net/download/core). If you have problems with the installation on macOS, consult the [Known issues & workarounds](https://github.com/dotnet/core/blob/master/cli/known-issues.md) topic. | ||
| Download and install the .NET Core SDK from [.NET Downloads](https://www.microsoft.com/net/download/core). If you have problems with the installation on macOS, consult the [Known issues](https://github.com/dotnet/core/tree/master/release-notes/2.0) topic for the version you have installed. |
There was a problem hiding this comment.
Do you want to remove the version (2.0) from the link? It does land on a higher page that lists the 1.0 and 1.1 release notes folders.
https://github.com/dotnet/core/tree/master/release-notes/
There was a problem hiding this comment.
☝️ perhaps not. Perhaps, the 2.0 bits for the release are best matched to the 2.0 release notes.
Versions ... hummm. 😉 😄
There was a problem hiding this comment.
Not for now. That page doesn't link to the Known issues topics. I did ask on the related issue if we should add those. Then, yes, we could change the link.
docs/core/macos-prerequisites.md
Outdated
|
|
||
| ## Visual Studio for Mac | ||
|
|
||
| You can use any editor of your choice to develop .NET Core applications using the .NET Core SDK. However, if you want to develop .NET Core applications on a Mac in an integrated development environment, you can use [Visual Studio for Mac](https://www.visualstudio.com/vs/visual-studio-mac/). |
There was a problem hiding this comment.
"You can use any editor" means it is "[their] choice." Can the "of your choice" phrase be dropped?
To avoid the "You can ..."; perhaps, just "Use ..." there. .... or something active like "Develop ..." or "Write code ..." or something like that.
Also, I thought that the conjunctive adverb with prep phrase immediately following it wouldn't get a comma (just like two prep phrases back-to-back opening a sentence; which of course is frowned upon by the style manual anyway). Perhaps, it would be simpler to just drop "However." It doesn't seem necessary. I'd suggest ...
With "However" ...
Use any editor to develop .NET Core applications using the .NET Core SDK. However if you want to develop .NET Core applications on a Mac in an integrated development environment, use [Visual Studio for Mac](https://www.visualstudio.com/vs/visual-studio-mac/).
or without "However" ...
Use any editor to develop .NET Core applications using the .NET Core SDK. If you want to develop .NET Core applications on a Mac in an integrated development environment, use [Visual Studio for Mac](https://www.visualstudio.com/vs/visual-studio-mac/).
There was a problem hiding this comment.
I prefer the can here. I'm not telling them what to do. I'm giving them options.
and for the commas with however, couldn't find anything in our style guide. But found this: https://writing.wisc.edu/Handbook/ConjAdv.html
Fixes #2492, related to dotnet/core#579
/cc @richlander @leecow