Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document new Roslyn Analyzer Rules for Wilson Token Validation #25911

Merged
merged 5 commits into from
Sep 8, 2021
Merged

Document new Roslyn Analyzer Rules for Wilson Token Validation #25911

merged 5 commits into from
Sep 8, 2021

Conversation

TimHannMSFT
Copy link
Contributor

Summary

  • CA5404: Do not disable token validation checks
  • CA5405: Do not always skip token validation in delegates

New Roslyn Analyzer Rules PR: dotnet/roslyn-analyzers#5420

@TimHannMSFT
Document new Roslyn Analyzer Rules for Wilson Token Validation
6aef336 
* CA5404: Do not disable token validation checks
* CA5405: Do not always skip token validation in delegates

New Roslyn Analyzer Rules PR: dotnet/roslyn-analyzers#5420
@dotnet-bot dotnet-bot added this to the September 2021 milestone Sep 1, 2021
@TimHannMSFT TimHannMSFT mentioned this pull request Sep 1, 2021
Merged
@gewarren gewarren added the 🚧 Hold for related PR Indicates a PR can only be merged when other related PRs are merged (see comments for links) label Sep 2, 2021
gewarren
gewarren reviewed Sep 2, 2021
View reviewed changes
Copy link
Contributor

@gewarren gewarren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding these. Please also add them to the TOC, the index for all CA rules, and the index for security rules.

TimHannMSFT and others added 3 commits September 2, 2021 09:07
@TimHannMSFT @gewarren
Apply suggestions from code review
688ddb6 
Incorporating Genevieve Warren's feedback/suggestions (much appreciated!)

Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com>
@TimHannMSFT
Add TOC, index and security-warning entries for both new rules.
fc64f00
@TimHannMSFT
Merge branch 'timhann/DocumentWilsonSecurityAnalyzers' of https://git…
e1a3c45 
…hub.com/TimHannMSFT/docs into timhann/DocumentWilsonSecurityAnalyzers
@TimHannMSFT TimHannMSFT requested a review from a team as a code owner September 2, 2021 16:29
@TimHannMSFT
Copy link
Contributor Author

Thanks for adding these. Please also add them to the TOC, the index for all CA rules, and the index for security rules.

Thanks for the pointer here (and the other suggestions). I think everything's incorporated now.

gewarren
gewarren reviewed Sep 2, 2021
View reviewed changes
Copy link
Contributor

@gewarren gewarren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple more small things to fix. I don't want to approve it until the analyzer itself is merged.

@TimHannMSFT @gewarren
Apply suggestions from code review
a687fbf 
Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com>
@kevinchalet kevinchalet mentioned this pull request Sep 6, 2021
Closed
@TimHannMSFT
Copy link
Contributor Author

Analyzer code has now been merged (dotnet/roslyn-analyzers#5420)

@TimHannMSFT TimHannMSFT requested a review from gewarren September 8, 2021 23:33
@gewarren gewarren merged commit a7951fc into dotnet:main Sep 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gewarren gewarren gewarren approved these changes

Assignees
No one assigned
Labels
🚧 Hold for related PR Indicates a PR can only be merged when other related PRs are merged (see comments for links) dotnet-fundamentals/svc
Projects
None yet
Milestone
September 2021
Development

Successfully merging this pull request may close these issues.
3 participants
@TimHannMSFT @gewarren @dotnet-bot