Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SYSLIB0032-SYSLIB0035 #25988

Merged
merged 2 commits into from
Sep 8, 2021
Merged

Add SYSLIB0032-SYSLIB0035 #25988

merged 2 commits into from
Sep 8, 2021

Conversation

gewarren
Copy link
Contributor

@gewarren gewarren commented Sep 8, 2021

Fixes #23856

@gewarren gewarren requested a review from a team as a code owner September 8, 2021 01:36
@dotnet-bot dotnet-bot added this to the September 2021 milestone Sep 8, 2021
@gewarren gewarren requested review from jkoritzinsky and bartonjs and removed request for jkoritzinsky September 8, 2021 01:41
Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM @gewarren

Once you and @bartonjs are happy, you can :shipit:


## Workaround

Use the overload that accepts a <xref:System.Security.Cryptography.Pkcs.CmsSigner>, that is, <xref:System.Security.Cryptography.Pkcs.SignerInfo.ComputeCounterSignature(System.Security.Cryptography.Pkcs.CmsSigner)?displayProperty=nameWithType>.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"that is", or "such as"?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there's only one overload that applies, so "such as" wouldn't make sense to me.

@gewarren gewarren merged commit c46df5d into dotnet:main Sep 8, 2021
@gewarren gewarren deleted the syslib0035 branch September 8, 2021 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add new SYSLIB warnings
4 participants