Address System.Text.Json feedback from #24963 #26593
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tdykstra
changed the title
gewarren
approved these changes
Oct 27, 2021
docs/standard/serialization/system-text-json-migrate-from-newtonsoft-how-to.md
Outdated
Show resolved
Hide resolved
docs/standard/serialization/system-text-json-use-dom-utf8jsonreader-utf8jsonwriter.md
Outdated
Show resolved
Hide resolved
docs/standard/serialization/system-text-json-use-dom-utf8jsonreader-utf8jsonwriter.md
Outdated
Show resolved
Hide resolved
docs/standard/serialization/system-text-json-use-dom-utf8jsonreader-utf8jsonwriter.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com>
|
@gewarren Thanks for the review and corrections! |
layomia
reviewed
Nov 17, 2021
|
|
||
| ### JsonDocument is read-only | ||
|
|
||
| The <xref:System.Text.Json> DOM can't add, remove, or modify JSON elements. It's designed this way for performance and to reduce allocations for parsing common JSON payload sizes (that is, < 1 MB). If your scenario currently uses a modifiable DOM, one of the following workarounds might be feasible: | ||
| The <xref:System.Text.Json> DOM can't add, remove, or modify JSON elements. It's designed this way for performance and to reduce allocations for parsing common JSON payload sizes (that is, < 1 MB). |
There was a problem hiding this comment.
nit: The xref:System.Text.Json DOM -> JsonDocument
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #24212