Document raw string literals #29079
Merged
Document raw string literals #29079
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make the edits for raw string literals to most content. For the programming guide content, move samples, format and update existing content.
BillWagner
force-pushed
the
raw-string-literals
branch
from
2201459 to
7364f58
Compare
BillWagner
commented
Apr 15, 2022
BillWagner
commented
Apr 15, 2022
docs/csharp/programming-guide/strings/snippets/StringLiterals.cs
Outdated
Show resolved
Hide resolved
|
/cc @KathleenDollard if you want to review. |
docs/csharp/language-reference/builtin-types/reference-types.md
Outdated
Show resolved
Hide resolved
docs/csharp/language-reference/builtin-types/reference-types.md
Outdated
Show resolved
Hide resolved
docs/csharp/language-reference/builtin-types/reference-types.md
Outdated
Show resolved
Hide resolved
|
This markdown looks bad:
Who owns the markdown processing? |
Adding @mimisasouvanh See here This is a new feature in C# 11. It looks like the syntax coloring for docs doesn't support this feature yet. Where should I track this? |
Co-authored-by: CyrusNajmabadi <cyrus.najmabadi@gmail.com>
docs/csharp/language-reference/builtin-types/reference-types.md
Outdated
Show resolved
Hide resolved
docs/csharp/language-reference/builtin-types/reference-types.md
Outdated
Show resolved
Hide resolved
docs/csharp/language-reference/builtin-types/reference-types.md
Outdated
Show resolved
Hide resolved
| string multiLine = """ | ||
| "Hello World!" is typically the first program someone writes. | ||
| """; | ||
| string embeddedXML = """ |
There was a problem hiding this comment.
Do you know how we get mark down fixed for raw string literals? I just used a screens shot (Cyrus's suggestion)
tdykstra
approved these changes
Apr 15, 2022
docs/csharp/language-reference/builtin-types/reference-types.md
Outdated
Show resolved
Hide resolved
docs/csharp/language-reference/builtin-types/reference-types.md
Outdated
Show resolved
Hide resolved
docs/csharp/language-reference/builtin-types/reference-types.md
Outdated
Show resolved
Hide resolved
docs/csharp/language-reference/builtin-types/reference-types.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Tom Dykstra <tdykstra@microsoft.com>
IEvangelist
pushed a commit
to IEvangelist/docs
that referenced
this pull request
Apr 21, 2022
* Update existing samples Make the edits for raw string literals to most content. For the programming guide content, move samples, format and update existing content. * warnings, and move one more sample. * first draft is completed. * fix build warnings and proofread. * fix snippet tags. * Apply suggestions from code review Co-authored-by: CyrusNajmabadi <cyrus.najmabadi@gmail.com> * respond to feedback. * respond to feedback. * move raw interpolated string literals to code * Apply suggestions from code review Co-authored-by: Tom Dykstra <tdykstra@microsoft.com> * respond to feedback. Co-authored-by: CyrusNajmabadi <cyrus.najmabadi@gmail.com> Co-authored-by: Tom Dykstra <tdykstra@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #28941
Add raw string literals to the C# guide:
Internal review links:
The changes to the how to article weren't substantive. The location of the embedded sample code moved.
The article in the programming guide hadn't been updated in some time, so also had a general edit pass. You may want to disable whitespace to see the diffs more cleanly.