Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docs for SqlMoney.ToSqlInternalRepresentation #29900

Merged
merged 1 commit into from
Jun 21, 2022

Conversation

GrabYourPitchforks
Copy link
Member

Follow-up to #28911. Adds docs for SqlMoney.ToSqlInternalRepresentation to serve as a complement for the internal ctors previously documented.

I tried to mimic the pattern in other API docs like https://docs.microsoft.com/en-us/dotnet/framework/additional-apis/system.data.sqltypes.sqlstreamchars.close, but feel free to mold this PR as needed. :)

/cc @David-Engel

@GrabYourPitchforks GrabYourPitchforks requested a review from a team as a code owner June 17, 2022 03:02
@dotnet-bot dotnet-bot added this to the June 2022 milestone Jun 17, 2022
Copy link
Contributor

@gewarren gewarren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @GrabYourPitchforks!

@GrabYourPitchforks
Copy link
Member Author

@gewarren Is there a URL where we can see the PR deployed before it hits prod?

@gewarren
Copy link
Contributor

@gewarren Is there a URL where we can see the PR deployed before it hits prod?

Yes it's here: https://review.docs.microsoft.com/en-us/dotnet/framework/additional-apis/system.data.sqltypes.sqlmoney.tosqlinternalrepresentation?branch=pr-en-us-29900

(You can find it in the build report when you click Details on the OpenPublishing.Build status check.)

@GrabYourPitchforks
Copy link
Member Author

Thanks as always for the assist @gewarren. Much appreciated! :)

@David-Engel I'll hold this open for a little while longer just in case you wanted to provide any feedback. There's no rush at all.

@GrabYourPitchforks GrabYourPitchforks merged commit fa7f3bc into dotnet:main Jun 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants