Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MemoryCache breaking change #31770

Merged
merged 2 commits into from
Oct 17, 2022
Merged

MemoryCache breaking change #31770

merged 2 commits into from
Oct 17, 2022

Conversation

gewarren
Copy link
Contributor

@gewarren gewarren commented Oct 13, 2022 •
edited
Loading

@dotnet-bot dotnet-bot added this to the October 2022 milestone Oct 13, 2022
@ghost ghost added the 🏁 Release: .NET 7 Work items for the .NET 7 release label Oct 13, 2022
@gewarren gewarren requested review from maryamariyan and a team October 13, 2022 21:49
CamSoper
CamSoper approved these changes Oct 14, 2022
View reviewed changes
Copy link
Contributor

@CamSoper CamSoper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I found a typo you might check out.

docs/core/compatibility/core-libraries/7.0/memorycache-tracking.md Outdated Show resolved Hide resolved
@gewarren @CamSoper
Update docs/core/compatibility/core-libraries/7.0/memorycache-trackin…
bdd1847 
…g.md

Co-authored-by: Cam Soper <cam.soper@microsoft.com>
IEvangelist
IEvangelist approved these changes Oct 17, 2022
View reviewed changes
Copy link
Member

@IEvangelist IEvangelist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, :shipit: when you're ready.

@gewarren gewarren merged commit f7c1979 into dotnet:main Oct 17, 2022
@gewarren gewarren deleted the memorycacheoptions branch October 17, 2022 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CamSoper CamSoper CamSoper approved these changes

@IEvangelist IEvangelist IEvangelist approved these changes

@maryamariyan maryamariyan Awaiting requested review from maryamariyan

Assignees
No one assigned
Labels
🏁 Release: .NET 7 Work items for the .NET 7 release dotnet-fundamentals/svc
Projects
None yet
Milestone
October 2022
Development

Successfully merging this pull request may close these issues.

[Breaking change]: Extend MemoryCacheOptions with TrackLinkedCacheEntries
4 participants
@gewarren @CamSoper @IEvangelist @dotnet-bot